Closed Bug 1034159 Opened 6 years ago Closed 6 years ago

Camera may leak media buffers during race condition

Categories

(Firefox OS Graveyard :: Gaia::Camera, defect)

ARM
Gonk (Firefox OS)
defect
Not set
minor

Tracking

(Not tracked)

RESOLVED FIXED
2.0 S5 (4july)

People

(Reporter: aosmond, Assigned: aosmond)

Details

Attachments

(1 file)

GonkCameraSourceListener holds a weak reference to GonkCameraSource, to which it passes frames to when received from the hardware manager. If GonkCameraSource is destroyed just before a new frame is attempted to be processed, it will leak the MediaSource buffer, although I have yet to reproduce the condition.
Assignee: nobody → aosmond
Status: NEW → ASSIGNED
Attachment #8450366 - Flags: review?(mhabicher)
Comment on attachment 8450366 [details] [diff] [review]
bug1034159.patch, v1

Review of attachment 8450366 [details] [diff] [review]:
-----------------------------------------------------------------

Good catch.
Attachment #8450366 - Flags: review?(mhabicher) → review+
Re: the try attempt, failure in test 9 (LinkedList assert) looks to be unrelated.
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/928ae2f66258
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → 2.0 S5 (4july)
You need to log in before you can comment on or make changes to this bug.