1034175 - Don't store the SHA1 for individual commit review requests in the commit-id field

Status: RESOLVED FIXED

(MozReview Graveyard :: General, defect)

Description

[Steven MacLeod [:smacleod]]

This is preventing us from dealing with things like re-pushing review requests to a different review identifier, because commit-id's are supposed to be unique by repo.

We can store this information in extra_data instead, and maybe expose it in the review details using rbmozui or rbbz.

This allows us to create new review requests "willy-nilly", without fear of hitting collisions.

Comment 1

[(no longer active)]

Commit SHA1s should be unique even across repos, right?

Comment 2

[Steven MacLeod [:smacleod]]

(In reply to :Ehsan Akhgari (lagging on bugmail, needinfo? me!) from comment #1)
> Commit SHA1s should be unique even across repos, right?

When I say "because commit-id's are supposed to be unique by repo" I mean "repo" in the Review Board sense. When creating review requests on Review Board a commit-id can be provided specifying which commit the Review Request represents. This field is enforced as unique, so that you should only ever be reviewing a specific commit in a single location.

We're going to stop providing this commit-id as is because we want to break this constraint.

Comment 3

[(no longer active)]

Gotcha, please ignore me.  :-)

Comment 4

[Gregory Szorc [:gps]]

This will impact displaying commit URLs.

Comment 5

[Gregory Szorc [:gps]]

Changing this will cause lots of merge conflicts with bug 1034188. Since that bug has a patch, adding depends on.

Comment 6

[Steven MacLeod [:smacleod]]

https://hg.mozilla.org/hgcustom/version-control-tools/rev/9b4dd10bf28e