1034196 - [Flatfish] [Telephony] Disable Web Telephony in Flatfish builds

Status: RESOLVED DUPLICATE of bug 928643

(Core :: DOM: Device Interfaces, defect)

Description

[Joshua Smith [:joshua-s]]

On devices without cellular capabilities (e.g. Flatfish), the Web Telephony API is still present.  Please disable this API on unsupported devices to prevent errors and confusion.

Comment 1

[Kevin Grandon :kgrandon]

Seems like we have support for this, and it's a build problem?

http://mxr.mozilla.org/mozilla-central/source/modules/libpref/src/init/all.js#4147

Comment 2

[Joshua Smith [:joshua-s]]

According to kgrandon, we already have this implemented and just need to set "dom.telephony.enabled" to "false" for Flatfish builds.

Changing the bug title and information...

Comment 3

[Anthony Ricaud (:rik)]

Hsin-Yi: Do you think that makes sense to hide this API on the tablet?

Comment 4

[Joshua Smith [:joshua-s]]

What does navigator.mozTelephony return when it is disabled by the pref in https://mxr.mozilla.org/mozilla-central/source/modules/libpref/src/init/all.js#4147?  Would it return undefined?

I am asking because I tried adding |"dom.telephony.enabled": false| to https://github.com/mozilla-b2g/gaia/blob/master/build/config/tablet/settings.json, and navigator.mozTelephony still returned [Object object].

Comment 5

[Hsin-Yi Tsai (she/her) [:hsinyi]]

(In reply to Anthony Ricaud (:rik) from comment #3)
> Hsin-Yi: Do you think that makes sense to hide this API on the tablet?

Yes, and we've done this. See Bug 914182 and Bug 920551.
 (In reply to Joshua Smith [:joshua-s] from comment #4)
> What does navigator.mozTelephony return when it is disabled by the pref in
> https://mxr.mozilla.org/mozilla-central/source/modules/libpref/src/init/all.
> js#4147?  Would it return undefined?
> 

It should return undefined.

> I am asking because I tried adding |"dom.telephony.enabled": false| to
> https://github.com/mozilla-b2g/gaia/blob/master/build/config/tablet/settings.
> json, and navigator.mozTelephony still returned [Object object].

Comment 6

[Vicamo Yang [:vicamo][:vyang]]

(In reply to Joshua Smith [:joshua-s] from comment #4)
> What does navigator.mozTelephony return when it is disabled by the pref in
> https://mxr.mozilla.org/mozilla-central/source/modules/libpref/src/init/all.
> js#4147?  Would it return undefined?
> 
> I am asking because I tried adding |"dom.telephony.enabled": false| to
> https://github.com/mozilla-b2g/gaia/blob/master/build/config/tablet/settings.
> json, and navigator.mozTelephony still returned [Object object].

bug 928643, the correct way at present should be passing --disable-b2g-ril to Gecko via either default-gecko-config or GECKO_CONFIGURE_ARGS in any of Android.mk you have, BoardConfig.mk is recommended, of course.

Comment 7

[Vicamo Yang [:vicamo][:vyang]]

I'm resolving this as duplicated because this is supposed to have been resolved in bug 928643.