Closed Bug 1034231 Opened 8 years ago Closed 8 years ago

Modify test_offlineCopy.js to use Promises.

Categories

(MailNews Core :: Testing Infrastructure, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 33.0

People

(Reporter: sshagarwal, Assigned: sshagarwal)

References

Details

Attachments

(1 file)

We intend to modify test_offlineCopy.js to use Promises instead of
asyncTestUtils.js
Attached patch Patch v1Splinter Review
Attachment #8450442 - Flags: review?(kent)
Comment on attachment 8450442 [details] [diff] [review]
Patch v1

Review of attachment 8450442 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good! The PromiseTestUtils are really starting to work now in these conversions! I like the way we could reuse the PromiseStreamListener as is.
Attachment #8450442 - Flags: review?(kent) → review+
Thanks.
Assignee: nobody → syshagarwal
Status: NEW → ASSIGNED
Keywords: checkin-needed
https://hg.mozilla.org/comm-central/rev/f06077644048
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 33.0
You need to log in before you can comment on or make changes to this bug.