Closed Bug 1034231 Opened 9 years ago Closed 9 years ago

Modify test_offlineCopy.js to use Promises.

Categories

(MailNews Core :: Testing Infrastructure, defect)

Product:
MailNews Core
Component:
Testing Infrastructure
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Thunderbird 33.0

People

(Reporter: sshagarwal, Assigned: sshagarwal)

References

Details

Attachments

(1 file)

Patch v1
10.94 KB, patch
rkent
: review+
Details | Diff | Splinter Review 
We intend to modify test_offlineCopy.js to use Promises instead of
asyncTestUtils.js
Attached patch Patch v1 — — Splinter Review 

        Attachment #8450442 -
        Flags: review?(kent)

    
    

    
  
Comment on attachment 8450442 [details] [diff] [review]
Patch v1

Review of attachment 8450442 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good! The PromiseTestUtils are really starting to work now in these conversions! I like the way we could reuse the PromiseStreamListener as is.

        Attachment #8450442 -
        Flags: review?(kent) → review+

    
    

    
  
Thanks.
Assignee: nobody → syshagarwal
Status: NEW → ASSIGNED
Keywords: checkin-needed

    
    

    
  
https://hg.mozilla.org/comm-central/rev/f06077644048
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 33.0

          You need to log in
          before you can comment on or make changes to this bug.