1034279 - USSD messages not displayed if user leaves Dialer while sending

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Dialer, defect)

Description

[Anthony Ricaud (:rik)]

STRs:
1) Compose a MMI and call it
2) While the "Sending…" screen is displayed, press the home button

Expected:
Dialer comes to the foreground with the MMI displayed.

Actual:
MMI is displayed but in the background.

Comment 1

[Anthony Ricaud (:rik)]

I have a patch for this but no tests yets. Will write those tomorrow.

Comment 2

[Anthony Ricaud (:rik)]

Attachment: https://github.com/mozilla-b2g/gaia/pull/21396

Comment 3

[Anthony Ricaud (:rik)]

https://github.com/mozilla-b2g/gaia/commit/46bad9d7f31cbc79a4551b011529156ba8f1f8c7

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/260f564d83f6

Comment 6

[Gabriele Svelto [:gsvelto]]

Thanks to the report in bug 1063407 we could better ascertain the impact of this issue: we thought it was a corner case but instead it's needed for STK to work properly from the settings app. One of our partners is asking for landing this on v1.4 (see bug 1063407 comment 6). This has been in master for a long time now and it's well tested but I'm not sure if we're still taking uplifts to v1.4. How should we proceed?

Comment 7

[Benjamin Kerensa [:bkerensa]]

Changing NI to Bhavana.

Comment 8

[bhavana bajaj [:bajaj]]

(In reply to Gabriele Svelto [:gsvelto] from comment #6)
> Thanks to the report in bug 1063407 we could better ascertain the impact of
> this issue: we thought it was a corner case but instead it's needed for STK
> to work properly from the settings app. One of our partners is asking for
> landing this on v1.4 (see bug 1063407 comment 6). This has been in master
> for a long time now and it's well tested but I'm not sure if we're still
> taking uplifts to v1.4. How should we proceed?

Given the DUP and the user impact here I'll block this on 1.4. can you please seek the approval for 1.4 and 2.0 to get this landed on those branches ? (filling the form once should be enough)

Comment 9

[Gabriele Svelto [:gsvelto]]

Attachment: Cherry-picked patch for v1.4

This is the cherry-picked patch for v1.4. The only change it required was removing the changes from the mmi_ui_test.js file which was not present in v1.4. The rest of the patch applied cleanly.

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): bug 1016885
[User impact] if declined: Interaction with the STK in the Settings app is partially broken, see bug 1063407
[Testing completed]: Covered with unit-tests and tested on an affected device, see bug 1063407 comment 5
[Risk to taking this patch] (and alternatives if risky): This patch has been in master for a long time already and proved to work well
[String changes made]: None

Comment 10

[Gabriele Svelto [:gsvelto]]

Attachment: Cherry-picked patch for v2.0

The patch applies cleanly to v2.0, I'm attaching here nonetheless for requesting approval. See comment 9 for the details. The same patch can be applied to v2.0m too though I'm not sure what's the landing policy for that branch.

Comment 11

[Ryan VanderMeulen [:RyanVM]]

2.0m is managed by the devices team, so you needn't worry about it :)

Comment 12

[Gabriele Svelto [:gsvelto]]

(In reply to Ryan VanderMeulen [:RyanVM UTC-4] from comment #11)
> 2.0m is managed by the devices team, so you needn't worry about it :)

Thanks, good to know :)

Comment 13

[Ryan VanderMeulen [:RyanVM]]

v2.0: https://github.com/mozilla-b2g/gaia/commit/3f4c635106c5364228782d12b1cb76b0c105b971
v1.4: https://github.com/mozilla-b2g/gaia/commit/6018a1c18f0c3eab25aac2ba3064904740591dd2

Comment 14

[Kai-Zhen Li [:seinlin][:kli]]

v2.0m: https://github.com/mozilla-b2g/gaia/commit/3f4c635106c5364228782d12b1cb76b0c105b971

Comment 15

[Shine(Leave from Mozilla)]

Verify OK, this issue can't repro on Woodduck 2.0.
Attached: Verify video.MP4
Reproducing rate: 5/5

Woodduck 2.0 Build:
Gaia-Rev        7bc7f75d712ccef535fd371bfcc7fe61dcdcf874
Gecko-Rev       8f21e6d8abf8ee01d8da066495d8febf3138375a
Build-ID        20141113050313
Version         32.0

Comment 16

[Shine(Leave from Mozilla)]

Attachment: video

Comment 17

[Gabriele Svelto [:gsvelto]]

Please don't attach confidential information (in this case the device shown in attachment 8522000 [details]) to a public bug and then make it confidential. This bug has been public since it was opened and needs to remain so in order for people to refer to it when analyzing the related code / commit. Please remove the video and make this bug public again.

Comment 18

[Sue]

Attachment: verify_video.MP4

This issue has been verified successfully on Flame v2.1 & v2.0
See attachment: verify_video.MP4
Reproducing rate: 0/5
Flame 2.1 versions:
Gaia-Rev        38e17b0219cbc50a4ad6f51101898f89e513a552
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/8b92c4b8f59a
Build-ID        20141205001201
Version         34.0
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  eng.cltbld.20141205.035305
FW-Date         Fri Dec  5 03:53:16 EST 2014
Bootloader      L1TC00011880

Flame 2.0 versions:
Gaia-Rev        856863962362030174bae4e03d59c3ebbc182473
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g32_v2_0/rev/e40fe21e37f1
Build-ID        20141207000206
Version         32.0
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  eng.cltbld.20141207.034341
FW-Date         Sun Dec  7 03:43:52 EST 2014
Bootloader      L1TC00011880