1034287 - Integrate Structured Logging with Gaia Build Tests

Status: RESOLVED INCOMPLETE

(Testing :: Mozbase, defect)

Description

[Chris Manchester (limited bugmail, email directly)]

This will mean implementing a structured mocha reporter like this: https://github.com/mozilla-b2g/mocha-tbpl-reporter/blob/3a5857a8dfbde57fbe541fdf82517970b5d9bdd1/lib/tbpl.js

Comment 1

[Chris Manchester (limited bugmail, email directly)]

Just so I have the link somewhere, it looks like: https://github.com/mozilla-b2g/mocha-socket-reporter provides messages in the mozlog format now.

Comment 2

[Chris Manchester (limited bugmail, email directly)]

I'm looking at this now and it looks like what's needed is a frankensteinesque combination of the mocha-socket-reporter to get JSON in the desired format and the mocha-tbpl-reporter to dump it to the console. This is going to be a DRY violation (but not a huge one). Andrew, do you know of a way to separate the message formatting from the transport in a mocha reporter, or should I bite the bullet here?

Comment 3

[Andrew Halberstadt [:ahal]]

Why can't whatever is receiving the structured logs over the socket do the formatting/dumping?

Comment 4

[Chris Manchester (limited bugmail, email directly)]

Looks like the gaia build and integration tests can end up sharing a solution here. I'm thinking just a clone of mocha-socket-reporter that replaces result.send calls with console.log ... but maybe we can do better?

Comment 5

[Andrew Halberstadt [:ahal]]

Yeah, that's probably the easiest way to move quickly.

Comment 6

[Chris Manchester (limited bugmail, email directly)]

I have an initial version of this (passing its own tests) at https://github.com/chmanchester/mocha-structured-reporter Making use of it is going to depend on an established way to consume structured logs in mozharness.