Closed Bug 1034298 Opened 10 years ago Closed 9 years ago

Warn about changes to proxy auto-config preferences

Categories

(addons.mozilla.org Graveyard :: Add-on Validation, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
2015-02

People

(Reporter: kmag, Assigned: kmag)

References

Details

(Whiteboard: [ReviewTeam:P2])

We need to warn about changes to proxy auto-config preferences ('network.proxy.autoconfig_url') for two reasons:

1) Remote proxy auto-config scripts are not allowed, since they can change at any time and therefore can't be reliably reviewed.

2) Only one add-on may change register an auto-config URL at once, while there are many which have reason to do so.

Add-ons which use remote PAC URLs need to be rejected for remote script use, and add-ons which use local or generated PAC scripts need to be redirected to use proxy filters (https://developer.mozilla.org/en-US/docs/XPCOM_Interface_Reference/nsIProtocolProxyService#registerFilter()) instead.
Whiteboard: [ReviewTeam]
Whiteboard: [ReviewTeam] → [ReviewTeam:P2]
Assignee: nobody → kmaglione+bmo
Target Milestone: --- → 2015-02
Blocks: 1175332
PR 62 was merged in https://github.com/mozilla/amo-validator/commit/f2314d8aa0bde352308802439306f9c67a117da8, anything missing for this bug to be marked as fixed?
Flags: needinfo?(kmaglione+bmo)
Status: NEW → RESOLVED
Closed: 9 years ago
Flags: needinfo?(kmaglione+bmo)
Resolution: --- → FIXED
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.