103430 - move testserver into mozilla/tools as an optional tool and then remove it from there

Status: RESOLVED FIXED

(Core :: Networking, defect)

Description

[Darin Fisher]

in an effort to reduce the required checkout size, i think testserver should
probably be moved to mozilla/tools as an optional tool.

Comment 1

[Bradley Baetz (:bbaetz)]

Yeah. Can we get someone to just copy/move the cvs files in the repository so
that we keep the history?

Comment 2

[Darin Fisher]

perhaps myk could help with this?

Comment 3

[Myk Melez [:myk] [@mykmelez]]

What is testserver, what does it do, where is it at now?

Comment 4

[Darin Fisher]

mozilla/netwerk/testserver

is a simple HTTP server written in Java that can be customized to send back any
HTTP response.  it is a useful tool for debugging HTTP networking problems.

Comment 5

[Darin Fisher]

catch myk! ;-)

Comment 6

[Dave Miller [:justdave]]

Note that we can't remove these from the previous location without breaking
existing cvs checkouts.  It would need to be copied, then use "cvs remove" on
the remaining files in the old location.

Comment 7

[Dave Miller [:justdave]]

btw, I have a good procedure down for doing this stuff, and I can take care of
it, but I'm not sure who the appropriate people are to approve this sort of
thing for this particular chunk of code, and I'm not going to do it without
someone in a position of authority saying it's okay. :)  Does that happen to be
Darin? :)

Comment 8

[Darin Fisher]

yes, you have module owner approval from me for this.  thanks!

Comment 9

[Dave Miller [:justdave]]

Directory copy has been completed.  The directory at the new location exists
only on the trunk (not on any branches) and will need to be rebranched if you
need it on a branch.  It will still need to be cvs deleted from the old location
if you want it gone from there.  (cvs delete all of the files within the
directories, don't worry about the directories themselves, they'll go away with
-P on a checkout.

Comment 10

[Phil Ringnalda (:philor)]

Nice - I was thinking about removing it from tools/, since at this point there's next to no chance of anyone using a Java test server that's been abandoned for nine years when they could use a JavaScript server that's actively developed and tested, when lo and behold, I find *another* copy of it in netwerk/! Guess that "reduce the checkout size" thing didn't quite work out.

Comment 11

[Phil Ringnalda (:philor)]

Attachment: rm

Two for the price of zero.

Comment 12

[Phil Ringnalda (:philor)]

(Pretend I removed the line in toolkit/toolkit-makefiles.sh _before_ I qdiffed, instead of after.)

Comment 13

[Jason Duell]

Comment on attachment 382221 [details] [diff] [review]
rm

Boris,

So this patch just finally deletes an entire directory of code that Darin agreed to purge years ago.  Tested the patch, it works fine.  Figure it's not worth bothering biesi on this, unless you're not comfortable approving.  Seems pretty clear this is dead code...

Comment 14

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 382221 [details] [diff] [review]
rm

Sure, especially since the JS test server actually does allow arbitrary responses now.

Comment 15

[Jason Duell]

CC-ing waldo just in case he knows of any reason why we'd keep this.  But I doubt it.

Comment 17

[Phil Ringnalda (:philor)]

http://hg.mozilla.org/mozilla-central/rev/7a93c28158e7