1034307 - nsTextEditorControlFrame logs "ASSERTION: Cannot bind twice, need to unbind first" in print preview

Status: NEW

(Core :: Layout: Form Controls, defect)

Description

[Seth Fowler [:seth] [:s2h]]

After fixing bug 1027611 I still got tons of assertion failures from the test case in that document. Bug 1027611 was caused by bug 63895, but I built an old revision of Firefox and established that these assertions are present before bug 63895 landed. They must be unrelated.

All the assertions look like this:

> 0:09.05 [6393] ###!!! ASSERTION: Cannot bind twice, need to unbind first: '!mBoundFrame', file /Users/mfowler/Code/mozdev/content/html/content/src/nsTextEditorState.cpp, line 1074
> 0:09.07 nsTextEditorState::BindToFrame(nsTextControlFrame*)+0x000000F8 [/Users/mfowler/Code/mozdev/obj/dist/NightlyDebug.app/Contents/MacOS/XUL +0x028F9DF8]
> 0:09.08 mozilla::dom::HTMLInputElement::BindToFrame(nsTextControlFrame*)+0x00000038 [/Users/mfowler/Code/mozdev/obj/dist/NightlyDebug.app/Contents/MacOS/XUL +0x02852988]
> 0:09.08 non-virtual thunk to mozilla::dom::HTMLInputElement::BindToFrame(nsTextControlFrame*)+0x0000002F [/Users/mfowler/Code/mozdev/obj/dist/NightlyDebug.app/Contents/MacOS/XUL +0x028529CF]
> 0:09.08 nsTextControlFrame::CreateAnonymousContent(nsTArray<nsIAnonymousContentCreator::ContentInfo>&)+0x00000119 [/Users/mfowler/Code/mozdev/obj/dist/NightlyDebug.app/Contents/MacOS/XUL +0x0316E099]
> 0:09.08 non-virtual thunk to nsTextControlFrame::CreateAnonymousContent(nsTArray<nsIAnonymousContentCreator::ContentInfo>&)+0x0000002F [/Users/mfowler/Code/mozdev/obj/dist/NightlyDebug.app/Contents/MacOS/XUL +0x0316EE7F]
> 0:09.09 nsCSSFrameConstructor::GetAnonymousContent(nsIContent*, nsIFrame*, nsTArray<nsIAnonymousContentCreator::ContentInfo>&)+0x00000070 [/Users/mfowler/Code/mozdev/obj/dist/NightlyDebug.app/Contents/MacOS/XUL +0x02F8D010]
> 0:09.09 nsCSSFrameConstructor::ProcessChildren(nsFrameConstructorState&, nsIContent*, nsStyleContext*, nsIFrame*, bool, nsFrameItems&, bool, PendingBinding*, nsIFrame*)+0x000002CA [/Users/mfowler/Code/mozdev/obj/dist/NightlyDebug.app/Contents/MacOS/XUL +0x02F8467A]
> 0:09.09 nsCSSFrameConstructor::ConstructFrameFromItemInternal(nsCSSFrameConstructor::FrameConstructionItem&, nsFrameConstructorState&, nsIFrame*, nsFrameItems&)+0x00000F48 [/Users/mfowler/Code/mozdev/obj/dist/NightlyDebug.app/Contents/MacOS/XUL +0x02F8C298]
> 0:09.10 nsCSSFrameConstructor::ConstructFramesFromItem(nsFrameConstructorState&, nsCSSFrameConstructor::FrameConstructionItemList::Iterator&, nsIFrame*, nsFrameItems&)+0x00000228 [/Users/mfowler/Code/mozdev/obj/dist/NightlyDebug.app/Contents/MacOS/XUL +0x02F90518]
> 0:09.10 nsCSSFrameConstructor::ConstructFramesFromItemList(nsFrameConstructorState&, nsCSSFrameConstructor::FrameConstructionItemList&, nsIFrame*, nsFrameItems&)+0x000000F6 [/Users/mfowler/Code/mozdev/obj/dist/NightlyDebug.app/Contents/MacOS/XUL +0x02FFAE16]
> 0:09.10 nsCSSFrameConstructor::ProcessChildren(nsFrameConstructorState&, nsIContent*, nsStyleContext*, nsIFrame*, bool, nsFrameItems&, bool, PendingBinding*, nsIFrame*)+0x000007CE [/Users/mfowler/Code/mozdev/obj/dist/NightlyDebug.app/Contents/MacOS/XUL +0x02F84B7E]
> 0:09.11 nsCSSFrameConstructor::ConstructBlock(nsFrameConstructorState&, nsStyleDisplay const*, nsIContent*, nsIFrame*, nsIFrame*, nsStyleContext*, nsIFrame**, nsFrameItems&, nsIFrame*, PendingBinding*)+0x0000040A [/Users/mfowler/Code/mozdev/obj/dist/NightlyDebug.app/Contents/MacOS/XUL +0x02F880FA]
> 0:09.11 nsCSSFrameConstructor::ConstructNonScrollableBlock(nsFrameConstructorState&, nsCSSFrameConstructor::FrameConstructionItem&, nsIFrame*, nsStyleDisplay const*, nsFrameItems&)+0x0000021B [/Users/mfowler/Code/mozdev/obj/dist/NightlyDebug.app/Contents/MacOS/XUL +0x02F8C87B]
> 0:09.11 nsCSSFrameConstructor::ConstructFrameFromItemInternal(nsCSSFrameConstructor::FrameConstructionItem&, nsFrameConstructorState&, nsIFrame*, nsFrameItems&)+0x000006C3 [/Users/mfowler/Code/mozdev/obj/dist/NightlyDebug.app/Contents/MacOS/XUL +0x02F8BA13]
> 0:09.12 nsCSSFrameConstructor::ConstructFramesFromItem(nsFrameConstructorState&, nsCSSFrameConstructor::FrameConstructionItemList::Iterator&, nsIFrame*, nsFrameItems&)+0x00000228 [/Users/mfowler/Code/mozdev/obj/dist/NightlyDebug.app/Contents/MacOS/XUL +0x02F90518]
> 0:09.12 nsCSSFrameConstructor::ConstructFramesFromItemList(nsFrameConstructorState&, nsCSSFrameConstructor::FrameConstructionItemList&, nsIFrame*, nsFrameItems&)+0x000000F6 [/Users/mfowler/Code/mozdev/obj/dist/NightlyDebug.app/Contents/MacOS/XUL +0x02FFAE16]
> 0:09.12 nsCSSFrameConstructor::ProcessChildren(nsFrameConstructorState&, nsIContent*, nsStyleContext*, nsIFrame*, bool, nsFrameItems&, bool, PendingBinding*, nsIFrame*)+0x000007CE [/Users/mfowler/Code/mozdev/obj/dist/NightlyDebug.app/Contents/MacOS/XUL +0x02F84B7E]
> 0:09.13 nsCSSFrameConstructor::ConstructBlock(nsFrameConstructorState&, nsStyleDisplay const*, nsIContent*, nsIFrame*, nsIFrame*, nsStyleContext*, nsIFrame**, nsFrameItems&, nsIFrame*, PendingBinding*)+0x0000040A [/Users/mfowler/Code/mozdev/obj/dist/NightlyDebug.app/Contents/MacOS/XUL +0x02F880FA]
> 0:09.13 nsCSSFrameConstructor::ConstructNonScrollableBlock(nsFrameConstructorState&, nsCSSFrameConstructor::FrameConstructionItem&, nsIFrame*, nsStyleDisplay const*, nsFrameItems&)+0x0000021B [/Users/mfowler/Code/mozdev/obj/dist/NightlyDebug.app/Contents/MacOS/XUL +0x02F8C87B]
> 0:09.13 nsCSSFrameConstructor::ConstructFrameFromItemInternal(nsCSSFrameConstructor::FrameConstructionItem&, nsFrameConstructorState&, nsIFrame*, nsFrameItems&)+0x000006C3 [/Users/mfowler/Code/mozdev/obj/dist/NightlyDebug.app/Contents/MacOS/XUL +0x02F8BA13]
> 0:09.13 nsCSSFrameConstructor::ConstructFramesFromItem(nsFrameConstructorState&, nsCSSFrameConstructor::FrameConstructionItemList::Iterator&, nsIFrame*, nsFrameItems&)+0x00000228 [/Users/mfowler/Code/mozdev/obj/dist/NightlyDebug.app/Contents/MacOS/XUL +0x02F90518]
> 0:09.14 nsCSSFrameConstructor::ConstructFramesFromItemList(nsFrameConstructorState&, nsCSSFrameConstructor::FrameConstructionItemList&, nsIFrame*, nsFrameItems&)+0x000000F6 [/Users/mfowler/Code/mozdev/obj/dist/NightlyDebug.app/Contents/MacOS/XUL +0x02FFAE16]
> 0:09.14 nsCSSFrameConstructor::ProcessChildren(nsFrameConstructorState&, nsIContent*, nsStyleContext*, nsIFrame*, bool, nsFrameItems&, bool, PendingBinding*, nsIFrame*)+0x000007CE [/Users/mfowler/Code/mozdev/obj/dist/NightlyDebug.app/Contents/MacOS/XUL +0x02F84B7E]
> 0:09.14 nsCSSFrameConstructor::ConstructTableCell(nsFrameConstructorState&, nsCSSFrameConstructor::FrameConstructionItem&, nsIFrame*, nsStyleDisplay const*, nsFrameItems&)+0x000003BC [/Users/mfowler/Code/mozdev/obj/dist/NightlyDebug.app/Contents/MacOS/XUL +0x02F85C1C]
> 0:09.15 nsCSSFrameConstructor::ConstructFrameFromItemInternal(nsCSSFrameConstructor::FrameConstructionItem&, nsFrameConstructorState&, nsIFrame*, nsFrameItems&)+0x000006C3 [/Users/mfowler/Code/mozdev/obj/dist/NightlyDebug.app/Contents/MacOS/XUL +0x02F8BA13]
> 0:09.15 nsCSSFrameConstructor::ConstructFramesFromItem(nsFrameConstructorState&, nsCSSFrameConstructor::FrameConstructionItemList::Iterator&, nsIFrame*, nsFrameItems&)+0x00000228 [/Users/mfowler/Code/mozdev/obj/dist/NightlyDebug.app/Contents/MacOS/XUL +0x02F90518]
> 0:09.15 nsCSSFrameConstructor::ConstructFramesFromItemList(nsFrameConstructorState&, nsCSSFrameConstructor::FrameConstructionItemList&, nsIFrame*, nsFrameItems&)+0x000000F6 [/Users/mfowler/Code/mozdev/obj/dist/NightlyDebug.app/Contents/MacOS/XUL +0x02FFAE16]
> 0:09.16 nsCSSFrameConstructor::ProcessChildren(nsFrameConstructorState&, nsIContent*, nsStyleContext*, nsIFrame*, bool, nsFrameItems&, bool, PendingBinding*, nsIFrame*)+0x000007CE [/Users/mfowler/Code/mozdev/obj/dist/NightlyDebug.app/Contents/MacOS/XUL +0x02F84B7E]
> 0:09.16 nsCSSFrameConstructor::ConstructTableRowOrRowGroup(nsFrameConstructorState&, nsCSSFrameConstructor::FrameConstructionItem&, nsIFrame*, nsStyleDisplay const*, nsFrameItems&)+0x00000322 [/Users/mfowler/Code/mozdev/obj/dist/NightlyDebug.app/Contents/MacOS/XUL +0x02F85552]
> 0:09.16 nsCSSFrameConstructor::ConstructFrameFromItemInternal(nsCSSFrameConstructor::FrameConstructionItem&, nsFrameConstructorState&, nsIFrame*, nsFrameItems&)+0x000006C3 [/Users/mfowler/Code/mozdev/obj/dist/NightlyDebug.app/Contents/MacOS/XUL +0x02F8BA13]
> 0:09.17 nsCSSFrameConstructor::ConstructFramesFromItem(nsFrameConstructorState&, nsCSSFrameConstructor::FrameConstructionItemList::Iterator&, nsIFrame*, nsFrameItems&)+0x00000228 [/Users/mfowler/Code/mozdev/obj/dist/NightlyDebug.app/Contents/MacOS/XUL +0x02F90518]
> 0:09.17 nsCSSFrameConstructor::ConstructFramesFromItemList(nsFrameConstructorState&, nsCSSFrameConstructor::FrameConstructionItemList&, nsIFrame*, nsFrameItems&)+0x000000F6 [/Users/mfowler/Code/mozdev/obj/dist/NightlyDebug.app/Contents/MacOS/XUL +0x02FFAE16]
> 0:09.17 nsCSSFrameConstructor::ProcessChildren(nsFrameConstructorState&, nsIContent*, nsStyleContext*, nsIFrame*, bool, nsFrameItems&, bool, PendingBinding*, nsIFrame*)+0x000007CE [/Users/mfowler/Code/mozdev/obj/dist/NightlyDebug.app/Contents/MacOS/XUL +0x02F84B7E]
> 0:09.18 nsCSSFrameConstructor::CreateContinuingTableFrame(nsIPresShell*, nsPresContext*, nsIFrame*, nsIFrame*, nsIContent*, nsStyleContext*)+0x000002EB [/Users/mfowler/Code/mozdev/obj/dist/NightlyDebug.app/Contents/MacOS/XUL +0x02F9B95B]
> 0:09.18 nsCSSFrameConstructor::CreateContinuingFrame(nsPresContext*, nsIFrame*, nsIFrame*, bool)+0x000003A7 [/Users/mfowler/Code/mozdev/obj/dist/NightlyDebug.app/Contents/MacOS/XUL +0x02F9AC67]
> 0:09.18 nsCSSFrameConstructor::CreateContinuingOuterTableFrame(nsIPresShell*, nsPresContext*, nsIFrame*, nsIFrame*, nsIContent*, nsStyleContext*)+0x000000B5 [/Users/mfowler/Code/mozdev/obj/dist/NightlyDebug.app/Contents/MacOS/XUL +0x02F9A825]
> 0:09.19 nsCSSFrameConstructor::CreateContinuingFrame(nsPresContext*, nsIFrame*, nsIFrame*, bool)+0x00000362 [/Users/mfowler/Code/mozdev/obj/dist/NightlyDebug.app/Contents/MacOS/XUL +0x02F9AC22]
> 0:09.19 nsBlockFrame::CreateContinuationFor(nsBlockReflowState&, nsLineBox*, nsIFrame*)+0x00000078 [/Users/mfowler/Code/mozdev/obj/dist/NightlyDebug.app/Contents/MacOS/XUL +0x03047C98]
> 0:09.19 nsBlockFrame::ReflowBlockFrame(nsBlockReflowState&, nsLineList_iterator, bool*)+0x00000FD7 [/Users/mfowler/Code/mozdev/obj/dist/NightlyDebug.app/Contents/MacOS/XUL +0x030448A7]

Comment 1

[Mats Palmgren (inactive)]

Attachment: testcase (asserts in Print Preview)