1034308 - RtspMediaResource uses the NS_DECL_NSISTREAMINGPROTOCOLLISTENER macro, but does not inherit from nsIStreamingProtocolListener

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

This fails to compile once we add MOZ_OVERRIDE annotations to the macros produced by the XPIDL compiler.  We should either write out the functions by hand or explicitly inherit from nsIStreamingProtocolListener.

Comment 1

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Attachment: Patch

Comment 2

[Ethan Tseng [:ethan]]

(In reply to Kyle Huey [:khuey] ([e-mail]) from comment #0)
> This fails to compile once we add MOZ_OVERRIDE annotations to the macros
> produced by the XPIDL compiler.  We should either write out the functions by
> hand or explicitly inherit from nsIStreamingProtocolListener.

Kyle, thanks for you patch!

Conceptually, we want to keep the relationships between RtspMediaResource and nsIStreamingProtocolListener being loosely coupled. We wouldn't like to make RtspMediaResource inherit from nsIStreamingProtocolListener. So, declare those functions by hand would be better. :)

Comment 3

[Ethan Tseng [:ethan]]

Comment on attachment 8467348 [details] [diff] [review]
Patch

Review of attachment 8467348 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good! Thanks, Kyle.

::: content/media/RtspMediaResource.h
@@ +230,1 @@
>  

nit: Please remove the trailing space in this line. :)

Comment 4

[Ethan Tseng [:ethan]]

Comment on attachment 8467348 [details] [diff] [review]
Patch

Review of attachment 8467348 [details] [diff] [review]:
-----------------------------------------------------------------

::: content/media/RtspMediaResource.h
@@ +225,5 @@
> +  nsresult OnMediaDataAvailable(uint8_t aIndex, const nsACString& aData,
> +                                uint32_t aLength, uint32_t aOffset,
> +                                nsIStreamingProtocolMetaData* aMeta);
> +  nsresult OnConnected(uint8_t aIndex, nsIStreamingProtocolMetaData* aMeta);
> +  nsresult OnDisconnected(uint8_t aIndex, nsresult aReason); 

Well, I mean this line.

Comment 5

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

(In reply to Ethan Tseng [:ethan] from comment #4)
> Comment on attachment 8467348 [details] [diff] [review]
> Patch
> 
> Review of attachment 8467348 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: content/media/RtspMediaResource.h
> @@ +225,5 @@
> > +  nsresult OnMediaDataAvailable(uint8_t aIndex, const nsACString& aData,
> > +                                uint32_t aLength, uint32_t aOffset,
> > +                                nsIStreamingProtocolMetaData* aMeta);
> > +  nsresult OnConnected(uint8_t aIndex, nsIStreamingProtocolMetaData* aMeta);
> > +  nsresult OnDisconnected(uint8_t aIndex, nsresult aReason); 
> 
> Well, I mean this line.

Fixed.

https://hg.mozilla.org/integration/b2g-inbound/rev/1c93a1e58c5c

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/1c93a1e58c5c