Closed Bug 1034314 Opened 7 years ago Closed 7 years ago

CR in template string hits "Assertion failure: lineStartOffsets_[lineIndex] == lineStartOffset"

Categories

(Core :: JavaScript Engine, defect)

x86_64
macOS
defect
Not set
critical

Tracking

()

RESOLVED FIXED
mozilla33

People

(Reporter: jruderman, Assigned: gupta.rajagopal)

References

(Blocks 1 open bug)

Details

(Keywords: assertion, regression, testcase)

Attachments

(1 file, 1 obsolete file)

eval("`z\r\r`")

Assertion failure: lineStartOffsets_[lineIndex] == lineStartOffset, at js/src/frontend/TokenStream.cpp:178

(`template strings` were added in bug 1021368 and bug 1031397.)
Changed call to peekChar into a call to peekRawChar. Added a test to catch this.
Attachment #8451765 - Flags: review?(jorendorff)
Comment on attachment 8451765 [details] [diff] [review]
Fix for Bug 1034314 - CR in template string hits assertion failure

Review of attachment 8451765 [details] [diff] [review]:
-----------------------------------------------------------------

Nice catch, good patch.
Attachment #8451765 - Flags: review?(jorendorff) → review+
Updated commit message to include r=jorendorff
Attachment #8451765 - Attachment is obsolete: true
Attachment #8452385 - Flags: review+
https://tbpl.mozilla.org/?tree=Try&rev=cccc19f7e386

checkin-needed - I am unable to include that in the keywords as the bug is not assigned to me.
Assignee: nobody → gupta.rajagopal
Status: NEW → ASSIGNED
Keywords: checkin-needed
(In reply to guptha from comment #4)
> I am unable to include that in the keywords as the bug is
> not assigned to me.

Fixed -- you now can confirm and edit bugs.  Use this power wisely.  :-)
https://hg.mozilla.org/mozilla-central/rev/8b581d352de9
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla33
You need to log in before you can comment on or make changes to this bug.