Closed Bug 1034315 Opened 7 years ago Closed 7 years ago

_OldCacheEntryWrapper uses NS_DECL_NSI... macros without inheriting from nsICacheEntryDescriptor

Categories

(Core :: Networking: Cache, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla34

People

(Reporter: khuey, Assigned: khuey)

References

Details

Attachments

(1 file)

Not sure if this is an oversight or what ...
That's correct.
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → INVALID
Well we need to do something here, because this blocks adding MOZ_OVERRIDE to the XPIDL macros for the rest of the tree.
Status: RESOLVED → REOPENED
Resolution: INVALID → ---
OK, we can expand the macros manually, they won't change anyway.  The _Old* code will go away in few release, so no need to have super nice code here.
Attached patch PatchSplinter Review
Assignee: nobody → khuey
Status: REOPENED → ASSIGNED
Attachment #8467347 - Flags: review?(honzab.moz)
Comment on attachment 8467347 [details] [diff] [review]
Patch

Review of attachment 8467347 [details] [diff] [review]:
-----------------------------------------------------------------

Sorry for delay.  Just get rid of the whitespaces and it's good to go.  Thanks!
Attachment #8467347 - Flags: review?(honzab.moz) → review+
https://hg.mozilla.org/mozilla-central/rev/7c6307643e90
Status: ASSIGNED → RESOLVED
Closed: 7 years ago7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla34
Flags: qe-verify-
You need to log in before you can comment on or make changes to this bug.