1034398 - Query for max IOSurf sizes

Status: RESOLVED FIXED

(Core :: Graphics: CanvasWebGL, defect)

Description

[Kelsey Gilbert [:jgilbert]]

Attachment: max-iosurfs

There's a way to query for the max size for IOSurfs, but we don't currently ask. We should ask.

Comment 1

[Benoit Girard (:BenWa)]

Comment on attachment 8450697 [details] [diff] [review]
max-iosurfs

Review of attachment 8450697 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/gl/SharedSurfaceIO.cpp
@@ +137,5 @@
> +                                 const SurfaceCaps& caps)
> +{
> +    gfx::IntSize maxDims(MacIOSurface::GetMaxWidth(),
> +                         MacIOSurface::GetMaxHeight());
> +    printf_stderr("[DONTLAND] IOSurf max: (%u,%u).\n",

DONTLAND

Comment 2

[Kelsey Gilbert [:jgilbert]]

(In reply to Benoit Girard (:BenWa) from comment #1)
> Comment on attachment 8450697 [details] [diff] [review]
> max-iosurfs
> 
> Review of attachment 8450697 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: gfx/gl/SharedSurfaceIO.cpp
> @@ +137,5 @@
> > +                                 const SurfaceCaps& caps)
> > +{
> > +    gfx::IntSize maxDims(MacIOSurface::GetMaxWidth(),
> > +                         MacIOSurface::GetMaxHeight());
> > +    printf_stderr("[DONTLAND] IOSurf max: (%u,%u).\n",
> 
> DONTLAND

Derp, sorry about that! (Glad it worked though!)

Comment 3

[Kelsey Gilbert [:jgilbert]]

Attachment: max-iosurfs

Comment 4

[Benoit Girard (:BenWa)]

Comment on attachment 8454764 [details] [diff] [review]
max-iosurfs

Review of attachment 8454764 [details] [diff] [review]:
-----------------------------------------------------------------

I meant to r+ the first time. Nothing else changed?

Comment 5

[Kelsey Gilbert [:jgilbert]]

(In reply to Benoit Girard (:BenWa) from comment #4)
> Comment on attachment 8454764 [details] [diff] [review]
> max-iosurfs
> 
> Review of attachment 8454764 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> I meant to r+ the first time. Nothing else changed?

Nope, just removed a pair of printfs.

Comment 6

[Kelsey Gilbert [:jgilbert]]

Attachment: max-iosurfs

r=benwa
https://tbpl.mozilla.org/?tree=Try&rev=cec66cbde9ee

Comment 7

[Kelsey Gilbert [:jgilbert]]

  https://hg.mozilla.org/integration/mozilla-inbound/rev/53f0f0e43ea5

Comment 8

[Kelsey Gilbert [:jgilbert]]

Oops, backed out in https://hg.mozilla.org/integration/mozilla-inbound/rev/7b2da264dd59

Comment 9

[Kelsey Gilbert [:jgilbert]]

  https://hg.mozilla.org/integration/mozilla-inbound/rev/7dd2566f4349

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/7dd2566f4349