Closed Bug 1034398 Opened 6 years ago Closed 6 years ago

Query for max IOSurf sizes

Categories

(Core :: Canvas: WebGL, defect)

Product:
Core
Component:
Canvas: WebGL
Platform:
All
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla33

People

(Reporter: jgilbert, Assigned: jgilbert)

Details

Attachments

(1 file, 2 obsolete files)

max-iosurfs
13.99 KB, patch
jgilbert
: review+
Details | Diff | Splinter Review
Attached patch max-iosurfs (obsolete) — — Splinter Review 
There's a way to query for the max size for IOSurfs, but we don't currently ask. We should ask.
Attachment #8450697 - Flags: review?(bgirard)
Comment on attachment 8450697 [details] [diff] [review]
max-iosurfs

Review of attachment 8450697 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/gl/SharedSurfaceIO.cpp
@@ +137,5 @@
> +                                 const SurfaceCaps& caps)
> +{
> +    gfx::IntSize maxDims(MacIOSurface::GetMaxWidth(),
> +                         MacIOSurface::GetMaxHeight());
> +    printf_stderr("[DONTLAND] IOSurf max: (%u,%u).\n",

DONTLAND
Attachment #8450697 - Flags: review?(bgirard) → review-
(In reply to Benoit Girard (:BenWa) from comment #1)
> Comment on attachment 8450697 [details] [diff] [review]
> max-iosurfs
> 
> Review of attachment 8450697 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: gfx/gl/SharedSurfaceIO.cpp
> @@ +137,5 @@
> > +                                 const SurfaceCaps& caps)
> > +{
> > +    gfx::IntSize maxDims(MacIOSurface::GetMaxWidth(),
> > +                         MacIOSurface::GetMaxHeight());
> > +    printf_stderr("[DONTLAND] IOSurf max: (%u,%u).\n",
> 
> DONTLAND

Derp, sorry about that! (Glad it worked though!)
Flags: needinfo?(jgilbert)
Attached patch max-iosurfs (obsolete) — — Splinter Review
Assignee: nobody → jgilbert
Attachment #8450697 - Attachment is obsolete: true
Attachment #8454764 - Flags: review?(bgirard)
Flags: needinfo?(jgilbert)
Comment on attachment 8454764 [details] [diff] [review]
max-iosurfs

Review of attachment 8454764 [details] [diff] [review]:
-----------------------------------------------------------------

I meant to r+ the first time. Nothing else changed?
Attachment #8454764 - Flags: review?(bgirard) → review+
(In reply to Benoit Girard (:BenWa) from comment #4)
> Comment on attachment 8454764 [details] [diff] [review]
> max-iosurfs
> 
> Review of attachment 8454764 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> I meant to r+ the first time. Nothing else changed?

Nope, just removed a pair of printfs.
Attached patch max-iosurfs — — Splinter Review 
r=benwa
https://tbpl.mozilla.org/?tree=Try&rev=cec66cbde9ee
Attachment #8454764 - Attachment is obsolete: true
Attachment #8454832 - Flags: review+
https://hg.mozilla.org/mozilla-central/rev/7dd2566f4349
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla33
You need to log in before you can comment on or make changes to this bug.