Closed
Bug 1034398
Opened 9 years ago
Closed 9 years ago
Query for max IOSurf sizes
Categories
(Core :: Graphics: CanvasWebGL, defect)
Tracking
()
RESOLVED
FIXED
mozilla33
People
(Reporter: jgilbert, Assigned: jgilbert)
Details
Attachments
(1 file, 2 obsolete files)
13.99 KB,
patch
|
jgilbert
:
review+
|
Details | Diff | Splinter Review |
There's a way to query for the max size for IOSurfs, but we don't currently ask. We should ask.
Attachment #8450697 -
Flags: review?(bgirard)
Comment 1•9 years ago
|
||
Comment on attachment 8450697 [details] [diff] [review] max-iosurfs Review of attachment 8450697 [details] [diff] [review]: ----------------------------------------------------------------- ::: gfx/gl/SharedSurfaceIO.cpp @@ +137,5 @@ > + const SurfaceCaps& caps) > +{ > + gfx::IntSize maxDims(MacIOSurface::GetMaxWidth(), > + MacIOSurface::GetMaxHeight()); > + printf_stderr("[DONTLAND] IOSurf max: (%u,%u).\n", DONTLAND
Attachment #8450697 -
Flags: review?(bgirard) → review-
Assignee | ||
Comment 2•9 years ago
|
||
(In reply to Benoit Girard (:BenWa) from comment #1) > Comment on attachment 8450697 [details] [diff] [review] > max-iosurfs > > Review of attachment 8450697 [details] [diff] [review]: > ----------------------------------------------------------------- > > ::: gfx/gl/SharedSurfaceIO.cpp > @@ +137,5 @@ > > + const SurfaceCaps& caps) > > +{ > > + gfx::IntSize maxDims(MacIOSurface::GetMaxWidth(), > > + MacIOSurface::GetMaxHeight()); > > + printf_stderr("[DONTLAND] IOSurf max: (%u,%u).\n", > > DONTLAND Derp, sorry about that! (Glad it worked though!)
Assignee | ||
Updated•9 years ago
|
Flags: needinfo?(jgilbert)
Assignee | ||
Comment 3•9 years ago
|
||
Assignee: nobody → jgilbert
Attachment #8450697 -
Attachment is obsolete: true
Attachment #8454764 -
Flags: review?(bgirard)
Flags: needinfo?(jgilbert)
Comment 4•9 years ago
|
||
Comment on attachment 8454764 [details] [diff] [review] max-iosurfs Review of attachment 8454764 [details] [diff] [review]: ----------------------------------------------------------------- I meant to r+ the first time. Nothing else changed?
Attachment #8454764 -
Flags: review?(bgirard) → review+
Assignee | ||
Comment 5•9 years ago
|
||
(In reply to Benoit Girard (:BenWa) from comment #4) > Comment on attachment 8454764 [details] [diff] [review] > max-iosurfs > > Review of attachment 8454764 [details] [diff] [review]: > ----------------------------------------------------------------- > > I meant to r+ the first time. Nothing else changed? Nope, just removed a pair of printfs.
Assignee | ||
Comment 6•9 years ago
|
||
r=benwa https://tbpl.mozilla.org/?tree=Try&rev=cec66cbde9ee
Attachment #8454764 -
Attachment is obsolete: true
Attachment #8454832 -
Flags: review+
Assignee | ||
Comment 7•9 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/53f0f0e43ea5
Assignee | ||
Comment 8•9 years ago
|
||
Oops, backed out in https://hg.mozilla.org/integration/mozilla-inbound/rev/7b2da264dd59
Assignee | ||
Comment 9•9 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/7dd2566f4349
Comment 10•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/7dd2566f4349
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla33
You need to log in
before you can comment on or make changes to this bug.
Description
•