1034403 - "ASSERTION: Getting CharProps for codepoint outside Unicode range" with small-caps

Status: RESOLVED FIXED

(Core :: Graphics: Text, defect)

Description

[Jesse Ruderman]

Attachment: testcase that asserts

###!!! ASSERTION: Getting CharProps for codepoint outside Unicode range: 'Not Reached', file intl/unicharutil/util/nsUnicodeProperties.cpp, line 51

The codepoint passed to GetCharProps2 is indeed outside the Unicode range: it is 4294967295.

Also affects <canvas> text methods.

Comment 1

[Jesse Ruderman]

Attachment: stack

Comment 2

[Jesse Ruderman]

Attachment: testcase that looks wrong

Comment 3

[Jesse Ruderman]

Somehow the second testcase renders as X∞≤ (X U+221E U+2264).

I have no idea how U+E0131 turns into U+221E U+2264.

Comment 4

[Jonathan Kew [:jfkthame]]

Attachment: update index to step past the second half of a surrogate pair.

Comment 5

[Jonathan Kew [:jfkthame]]

Comment on attachment 8450825 [details] [diff] [review]
update index to step past the second half of a surrogate pair.

I don't think this is quite right, actually; cancelling r? until I look more carefully.

Comment 6

[Jonathan Kew [:jfkthame]]

Attachment: update index to step past the second half of a surrogate pair.

Comment 7

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 8451175 [details] [diff] [review]
update index to step past the second half of a surrogate pair.

Review of attachment 8451175 [details] [diff] [review]:
-----------------------------------------------------------------

don't forget the test

Comment 8

[Jonathan Kew [:jfkthame]]

Pushed to inbound (including the asserting testcase):
https://hg.mozilla.org/integration/mozilla-inbound/rev/eed019320764

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/eed019320764