1034598 - Preview Pages with Macros Sometimes Fail Due to No Parent Page Path Access

Status: RESOLVED WONTFIX

(developer.mozilla.org Graveyard :: KumaScript, defect)

Description

[Soledad Penades [:sole] [:spenades]]

Attachment: Screenshot 2014-07-04 14.25.30.png

I'm getting this when editing https://developer.mozilla.org/en-US/docs/Web/API/Window.devicePixelRatio , and I have no clue why. Maybe because I entered some HTML in the content using the source editor?

I don't know, but this is a terrible user experience after having to wait for something like 45 seconds for the page to be created initially.

Comment 1

[Eric Shepherd [:sheppy]]

I can reproduce this both on the page shown in the screenshot and on other pages. Previewing pages that use the {{APIRef}} macro results in this error.

Comment 2

[David Walsh :davidwalsh]

Right away I can identify a big problem:

var pageFolders = pageURL.split('/');
if (pageFolders) { ... }

String.prototype.split returns an array, even if empty, so that will always be true.

The larger issue, I believe, is that the full page path and such isn't used by our preview page code, still looking into it.

Comment 3

[David Walsh :davidwalsh]

Ali:  How should we prioritize improvement of previews?  Is this a more or less important than other things?

This will take large effort.  Probably LOE5.

Comment 4

[ali spivak]

Added Justin, so he can help figure out where in the stack of other bugs this belongs. 

It looks like this particular bug only affects pages using the {{APIRef}} macro, correct? Do we have any idea how many pages use that macro, and how important they are? We're doing a lot of work on the API dos and encouraging others to write them, so its important the API pages & macros work optimally. 

In general, from a content/community point of view, preview bugs are usually P2, in that we can live with them for a short while, but they do need to get fixed because they are frustrating to people writing, and could cause newer contributors not to return.

Comment 5

[Luke Crouch [:groovecoder]]

needinfo? myself to find out how many users this affects ...

Comment 6

[Luke Crouch [:groovecoder]]

1168 documents use APIRef [1], 2,076 (0.01% of total) pageviews of preview-wiki-content since the bug was reported [2], and 36 of these errors in the last week. (New Relic)

[1] https://developer.mozilla.org/en-US/search?locale=*&kumascript_macros=APIRef
[2] https://www.google.com/analytics/web/?authuser=1#report/content-pages/a36116321w64965862p66726481/%3F_u.date00%3D20140704%26_u.date01%3D20140918%26explorer-table.filter%3Dpreview-wiki-content%26explorer-table.plotKeys%3D[]/

Comment 7

[David Walsh :davidwalsh]

Removing myself as assignee -- this isn't a kumascript bug, it's a preview page / processing bug.

Comment 8

[Sylvestre Ledru [:Sylvestre]]

No assignee, updating the status.

Comment 9

[Sylvestre Ledru [:Sylvestre]]

No assignee, updating the status.

Comment 10

[BMO Automation]

MDN Web Docs' bug reporting has now moved to GitHub. From now on, please file content bugs at https://github.com/mdn/sprints/issues/ and platform bugs at https://github.com/mdn/kuma/issues/.