Closed
Bug 1034619
Opened 11 years ago
Closed 11 years ago
Add comment for bug 961832
Categories
(DevTools Graveyard :: Graphic Commandline and Toolbar, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 33
People
(Reporter: sblin, Assigned: sblin)
Details
Attachments
(1 file, 1 obsolete file)
|
1.18 KB,
patch
|
sblin
:
review+
|
Details | Diff | Splinter Review |
On bug [1], I used scrollTo function. But it is not trivial to understand.
So I think we can add a comment above the scrollTo function.
[1]: https://bugzilla.mozilla.org/show_bug.cgi?id=961832
Attachment #8450983 -
Flags: review?(pbrosset)
|
||
Updated•11 years ago
|
Component: Untriaged → Developer Tools: Graphic Commandline and Toolbar
|
||
Comment 1•11 years ago
|
||
Comment on attachment 8450983 [details] [diff] [review]
comment-bug-961832.diff
Review of attachment 8450983 [details] [diff] [review]:
-----------------------------------------------------------------
Looks good to me. Simple comment change, no need for a try push for this.
Attachment #8450983 -
Flags: review?(pbrosset) → review+
|
|
||
Comment 2•11 years ago
|
||
One thing though, you'll need to change the commit message: "Just add a little comment" -> "Bug 1034619 - Add a comment to the screenshot gcli command; r=pbrosset"
Keywords: checkin-needed
Hardware: x86_64 → All
|
|
||
Updated•11 years ago
|
Keywords: checkin-needed
|
Assignee | |
Comment 3•11 years ago
|
||
Attachment #8450983 -
Attachment is obsolete: true
Attachment #8451019 -
Flags: review+
|
|
||
Comment 4•11 years ago
|
||
Asking for checkin of this patch without try push as this only adds 2 lines of comments.
Keywords: checkin-needed
|
||
Comment 5•11 years ago
|
||
Status: UNCONFIRMED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 33
|
||
Updated•7 years ago
|
Product: Firefox → DevTools
|
|
||
Updated•7 years ago
|
Product: DevTools → DevTools Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•