Closed Bug 1034619 Opened 7 years ago Closed 7 years ago

Add comment for bug 961832

Categories

(DevTools Graveyard :: Graphic Commandline and Toolbar, defect)

33 Branch
defect
Not set
trivial

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 33

People

(Reporter: sblin, Assigned: sblin)

Details

Attachments

(1 file, 1 obsolete file)

Attached patch comment-bug-961832.diff (obsolete) — Splinter Review
On bug [1], I used scrollTo function. But it is not trivial to understand.
So I think we can add a comment above the scrollTo function.

[1]: https://bugzilla.mozilla.org/show_bug.cgi?id=961832
Attachment #8450983 - Flags: review?(pbrosset)
Component: Untriaged → Developer Tools: Graphic Commandline and Toolbar
Comment on attachment 8450983 [details] [diff] [review]
comment-bug-961832.diff

Review of attachment 8450983 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me. Simple comment change, no need for a try push for this.
Attachment #8450983 - Flags: review?(pbrosset) → review+
One thing though, you'll need to change the commit message: "Just add a little comment" -> "Bug 1034619 - Add a comment to the screenshot gcli command; r=pbrosset"
Keywords: checkin-needed
Hardware: x86_64 → All
Attachment #8450983 - Attachment is obsolete: true
Attachment #8451019 - Flags: review+
Asking for checkin of this patch without try push as this only adds 2 lines of comments.
Keywords: checkin-needed
https://hg.mozilla.org/integration/fx-team/rev/1c3ec706f97b
Assignee: nobody → amarok
Keywords: checkin-needed
Whiteboard: [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/1c3ec706f97b
Status: UNCONFIRMED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 33
Product: Firefox → DevTools
Product: DevTools → DevTools Graveyard
You need to log in before you can comment on or make changes to this bug.