Closed Bug 1034722 Opened 10 years ago Closed 10 years ago

Upgrade virtualenv to 1.10.1 for TPS environment creation

Categories

(Testing Graveyard :: TPS, defect)

defect
Not set
normal

Tracking

(firefox31 fixed, firefox32 fixed, firefox33 fixed)

RESOLVED FIXED
mozilla33
Tracking Status
firefox31 --- fixed
firefox32 --- fixed
firefox33 --- fixed

People

(Reporter: whimboo, Assigned: whimboo)

Details

Attachments

(1 file, 1 obsolete file)

We detected problems with virtualenv 1.9.1 when installing the fxa-python-client into the environment. It totally failed to install some of its dependencies. Tests have shown that the package itself is a bit broken; that will be fixed with https://github.com/mozilla/fxa-python-client/pull/13.

But we also have to upgrade virtualenv so it can successfully install the package. I don't think we should upgrade to 1.11.x immediately given that is has some non-backward compatible changes. So 1.10.1 should be the best version for us at the moment.
Attached patch Upgrade venv to 1.10.1 v1 (obsolete) — Splinter Review
Attachment #8451562 - Flags: review?(jgriffin)
Comment on attachment 8451562 [details] [diff] [review]
Upgrade venv to 1.10.1 v1

Review of attachment 8451562 [details] [diff] [review]:
-----------------------------------------------------------------

lgtm
Attachment #8451562 - Flags: review?(jgriffin) → review+
Patch with updated commit message, so someone else can land it. Taking over r+.
Attachment #8451562 - Attachment is obsolete: true
https://hg.mozilla.org/mozilla-central/rev/ba917bb8b9b4
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Product: Testing → Testing Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: