Closed
Bug 1034803
Opened 11 years ago
Closed 11 years ago
treat local(serif) as an invalid value in descriptor_database.js
Categories
(Core :: CSS Parsing and Computation, defect)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
FIXED
mozilla33
People
(Reporter: heycam, Assigned: heycam)
References
Details
Attachments
(1 file)
|
1.35 KB,
patch
|
dbaron
:
review+
|
Details | Diff | Splinter Review |
We don't parse |src: local(serif)| in @font-face rules, so we should list that value as invalid in descriptor_database.js.
https://tbpl.mozilla.org/?tree=Try&rev=37834c7dcb4b
Attachment #8451223 -
Flags: review?(dbaron)
Comment on attachment 8451223 [details] [diff] [review]
patch
r=dbaron... but it seems like we should fix things so there's a test failure when a value is in the wrong half!
Attachment #8451223 -
Flags: review?(dbaron) → review+
|
Assignee | |
Comment 2•11 years ago
|
||
(In reply to David Baron [:dbaron] (UTC-7) (needinfo? for questions) from comment #1)
> r=dbaron... but it seems like we should fix things so there's a test failure
> when a value is in the wrong half!
Ideally the existing @font-face tests would catch that yes. Though my (as yet unlanded) Font Loading API tests in bug 1028497 will exercise these. (That's how I found it.)
|
|
Assignee | |
Comment 3•11 years ago
|
||
|
||
Comment 4•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla33
You need to log in
before you can comment on or make changes to this bug.
Description
•