1034844 - [rbmozui] Make diff selection better

Status: RESOLVED FIXED

(MozReview Graveyard :: General, defect, P2)

Description

[Steven MacLeod [:smacleod]]

I think there are a few things we could do in rbmozui to make diff selection and navigation much better.

Mike and I had talked before about having a "Commits" tab (in addition to the "Reviews" and "Diff" tab) where you could at a glance view information about which commits are part of the push and what review requests they are represented by. This tab would also allow for setting reviewers on particular commits all from the same page.

In addition to this commits tab, I think we could make navigation between diffs for each commit more streamlined, and maybe even reviews as well.

I'm envisioning two main modifications to accomplish this:

A) Modify, or extend, the diff revision selector on the view diff page to identify which push that diff revision came from.

We would identify the first push as "push0" and then each successive push would increment this counter (push1, push2, push3, etc). I'll refer to this as "Push Revision" Then we could annotate the diff revisions on the separate review requests with the Push Revision to identify the push that created it.

This would allow you to match up diff revisions between commits that were first created in different Push Revisions.

For example, the ways things are now, you could push 2 commits (C1, and C2) which would create 2 commit review requests (r1, and r2 respectively). If you then did another push with 3 commits (C1', C2', and C3) you would have 3 commit review requests (r1, r2, r3). r1 and r2 would both have two diff revisions ("orig", and "1"), but r3 would only have the single "orig" revision. What I propose in this case is that we'd annotate "orig" with push0, and "1" with push1 in the case of r1/r2, and in r3 we would annotate "orig" with push1.

This allows you to identify which diff revisions come from the same push and belong together as a unit. We *could* even replace the diff revision display with our Push Revision completely. I'm not sure what would work best.


B) Add in a "Commit Selector" above, or near, the diff revision selector.

This commit selector would display the commits which were part of the Push Revision for the currently displayed diff (i.e. If I'm viewing a diff from Push Revision 2, it would list the commits from Push Revision 2). You would be able to click a particular commit from this display, and it would jump you to the review request view diff page for that particular commit, and the currently displayed Push Revision.

The other option would be to ignore Push revision when displaying these commits, and just show the latest push revision + jump to the latest diff for that commit review request. This second method is much less complex and we wouldn't have to worry about what to display or where to jump when viewing interdiffs.

Really though it boils down to having a way to easily jump between the commits that were part of the push from the diff viewer.


The other thing to consider here is if we're going to have this commit display, and the ability to jump between them, on the diff viewer page, we could also stick it on the reviews page. I'm not sure if we want to do that the same way, or if it would obsolete the "Commits" tab.

I'd be interested to know what everyone else thinks about this stuff.

Comment 1

[Steven MacLeod [:smacleod]]

This is mostly fixed by having the commits table (which we keep improving).