Closed
Bug 1034908
Opened 10 years ago
Closed 10 years ago
The unused 'scope' argument to ErrorCopier::ErrorCopier and js_CopyErrorObject should be removed
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla33
People
(Reporter: jimb, Assigned: jimb)
Details
Attachments
(1 file)
|
11.66 KB,
patch
|
jorendorff
:
review+
|
Details | Diff | Splinter Review |
Try push: https://tbpl.mozilla.org/?tree=Try&rev=8e4edf1d8257
Attachment #8451309 -
Flags: review?(jorendorff)
|
Assignee | |
Comment 1•10 years ago
|
||
Try push looks good.
|
||
Comment 2•10 years ago
|
||
Comment on attachment 8451309 [details] [diff] [review] Remove the unused 'scope' argument to ErrorCopier::ErrorCopier and js_CopyErrorObject. Review of attachment 8451309 [details] [diff] [review]: ----------------------------------------------------------------- Thanks. r=me with one tweak. ::: js/src/jscompartment.h @@ +590,3 @@ > > public: > + ErrorCopier(mozilla::Maybe<AutoCompartment> &ac) Add 'explicit' here, please.
Attachment #8451309 -
Flags: review?(jorendorff) → review+
|
|
Assignee | |
Comment 3•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/23b19a772a42
|
|
Assignee | |
Comment 4•10 years ago
|
||
Added requested 'explicit': https://hg.mozilla.org/integration/mozilla-inbound/rev/4d02030db21b
Assignee: nobody → jimb
Status: NEW → ASSIGNED
Flags: in-testsuite-
Target Milestone: --- → mozilla33
|
||
Comment 5•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/23b19a772a42 https://hg.mozilla.org/mozilla-central/rev/4d02030db21b
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•