Closed Bug 1034911 Opened 7 years ago Closed 7 years ago

Remove dangerous public destructor of dom::KeyAlgorithm

Categories

(Core :: DOM: Security, defect)

Other Branch
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla33

People

(Reporter: bjacob, Assigned: mccr8)

References

Details

Attachments

(1 file)

In bug 1028588 we removed dangerous public destructors of XPCOM-refcounted classes outside of a finite whitelist, see HasDangerousPublicDestructor. Now we are going over the entries in this whitelist.

One of them is: dom::KeyAlgorithm
I was able to just delete the HasDangerousPublicDestructor<dom::KeyAlgorithm> structure, and it compiled, so I'm not sure what that means.  This is with a freshly updated trunk build.
I haven't yet landed the new static assertions in  bug 1028588 that catch this. I hope to land them later today.
Also, note that these static_assertions only do anything on Clang and GCC>=4.8.
Assignee: nobody → continuation
That's landed on inbound now.
Comment on attachment 8452485 [details] [diff] [review]
Make the destructor for KeyAlgorithm private.

Huh.
Attachment #8452485 - Flags: review?(bugs) → review+
https://hg.mozilla.org/mozilla-central/rev/72c27a72f8a8
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla33
You need to log in before you can comment on or make changes to this bug.