1034911 - Remove dangerous public destructor of dom::KeyAlgorithm

Status: RESOLVED FIXED

(Core :: DOM: Security, defect)

Description

[Benoit Jacob [:bjacob] (mostly away)]

In bug 1028588 we removed dangerous public destructors of XPCOM-refcounted classes outside of a finite whitelist, see HasDangerousPublicDestructor. Now we are going over the entries in this whitelist.

One of them is: dom::KeyAlgorithm

Comment 1

[Andrew McCreight [:mccr8]]

I was able to just delete the HasDangerousPublicDestructor<dom::KeyAlgorithm> structure, and it compiled, so I'm not sure what that means.  This is with a freshly updated trunk build.

Comment 2

[Benoit Jacob [:bjacob] (mostly away)]

I haven't yet landed the new static assertions in  bug 1028588 that catch this. I hope to land them later today.

Comment 3

[Benoit Jacob [:bjacob] (mostly away)]

Also, note that these static_assertions only do anything on Clang and GCC>=4.8.

Comment 4

[Benoit Jacob [:bjacob] (mostly away)]

That's landed on inbound now.

Comment 5

[Andrew McCreight [:mccr8]]

Attachment: Make the destructor for KeyAlgorithm private.

try run: https://tbpl.mozilla.org/?tree=Try&rev=a62593216ea0

Comment 6

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8452485 [details] [diff] [review]
Make the destructor for KeyAlgorithm private.

Huh.

Comment 7

[Andrew McCreight [:mccr8]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/72c27a72f8a8

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/72c27a72f8a8