If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Remove dangerous public destructor of nsHTMLURIRefObject

RESOLVED FIXED in mozilla33

Status

()

Core
Editor
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: bjacob, Assigned: mccr8)

Tracking

Other Branch
mozilla33
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

In bug 1028588 we removed dangerous public destructors of XPCOM-refcounted classes outside of a finite whitelist, see HasDangerousPublicDestructor. Now we are going over the entries in this whitelist.

One of them is: nsHTMLURIRefObject
(Assignee)

Updated

3 years ago
Assignee: nobody → continuation
(Assignee)

Comment 1

3 years ago
Created attachment 8452487 [details] [diff] [review]
Don't manually delete nsHTMLURIRefObject and enforce it.

try run: https://tbpl.mozilla.org/?tree=Try&rev=a62593216ea0
Attachment #8452487 - Flags: review?(ehsan)
Attachment #8452487 - Flags: review?(ehsan) → review+
(Assignee)

Comment 2

3 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/38ef35020b34
(Assignee)

Comment 3

3 years ago
Followup for what I think is non-unified build bustage:
  https://hg.mozilla.org/integration/mozilla-inbound/rev/71290fc83066
https://hg.mozilla.org/mozilla-central/rev/38ef35020b34
https://hg.mozilla.org/mozilla-central/rev/71290fc83066
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla33
You need to log in before you can comment on or make changes to this bug.