Remove dangerous public destructor of nsTXTToHTMLConv

RESOLVED FIXED in mozilla33

Status

()

Core
Networking
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: bjacob, Assigned: sworkman)

Tracking

Other Branch
mozilla33
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

In bug 1028588 we removed dangerous public destructors of XPCOM-refcounted classes outside of a finite whitelist, see HasDangerousPublicDestructor. Now we are going over the entries in this whitelist.

One of them is: nsTXTToHTMLConv
(Assignee)

Comment 1

4 years ago
Created attachment 8452118 [details] [diff] [review]
v1.0 Remove dangerous public destructor of nsTXTToHTMLConv

Did a bit of rejiggering to use NS_GENERIC_FACTORY_CONSTRUCTOR_INIT and removed now-redundant factory functions.

Just pushed to try: https://tbpl.mozilla.org/?tree=Try&rev=2379ec87d1ae
Assignee: nobody → sworkman
Status: NEW → ASSIGNED
Attachment #8452118 - Flags: review?(mcmanus)
Attachment #8452118 - Flags: review?(mcmanus) → review+
https://hg.mozilla.org/mozilla-central/rev/20479ebf9be8
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla33
You need to log in before you can comment on or make changes to this bug.