AccEventGen.py code generator should not generate dangerous public destructors in refcounted classes

RESOLVED FIXED in mozilla34

Status

()

RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: bjacob, Assigned: mccr8)

Tracking

Other Branch
mozilla34
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

In bug 1028588 we removed dangerous public destructors of XPCOM-refcounted classes outside of a finite whitelist, see HasDangerousPublicDestructor. Now we are going over the entries in this whitelist.

One such occurrence is in the AccEventGen.py code generator. It currently generates classes with public destructors, even though the classes are reference-counted. For that reason, in bug 1028588 we are making this code generator also generate HasDangerousPublicDestructor specializations for these classes.

But what we really want is no dangerous public destructors at all.
Component: DOM: Events → Disability Access APIs
(Reporter)

Comment 1

4 years ago
Hah - I was looking for "accessibility".
(Assignee)

Comment 2

4 years ago
Hmm. It seems to be okay to just make the dtor private here, which seems odd to me.
Assignee: nobody → continuation
(Assignee)

Comment 3

4 years ago
Created attachment 8463439 [details] [diff] [review]
Make AccEventGen.py code generator generate classes with private destructors.

try: https://tbpl.mozilla.org/?tree=Try&rev=09ff07ea3d51
Attachment #8463439 - Flags: review?(trev.saunders)
Comment on attachment 8463439 [details] [diff] [review]
Make AccEventGen.py code generator generate classes with private destructors.

thanks!
Attachment #8463439 - Flags: review?(trev.saunders) → review+
https://hg.mozilla.org/mozilla-central/rev/2fd5026e35f1
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla34
You need to log in before you can comment on or make changes to this bug.