1034973 - Crashes in mozalloc_abort(char const* const) | NS_DebugBreak | nsDebugImpl::Abort(char const*, int) with AsyncShutdownTimeout "CrashMonitor: Writing notifications to file after receiving profile-before-change"

Status: RESOLVED WORKSFORME

(Firefox Health Report Graveyard :: Client: Desktop, defect)

Description

[u279076]

See also bug 944872 comment 51.

I'm seeing a lot of these crashes reported in the wild.
1. Load https://crash-stats.mozilla.com/report/list?signature=mozalloc_abort%28char%20const*%20const%29%20|%20NS_DebugBreak%20|%20nsDebugImpl%3A%3AAbort%28char%20const*%2C%20int%29#tab-reports
2. Click "Change columns in this table" or scroll to the bottom of the page
3. Select "AsyncShutdownTimeout" from the "Available columns" list 
4. Click ">>" to add it to the list of "Chosen columns"
5. Click "Save and Reload"
6. Find in page "CrashMonitor: Writing notifications to file after receiving profile-before-change" and you'll see a lot of these crashes.

I don't know a good way to search crashstats to show only these crashes but based on what I'm seeing with Find In Page, I would guess it's in the thousands of crashes over the last week.

Comment 1

[David Teller [:Yoric] - still alive but not very active]

I suspect that bug 1008944 fixed these crashes. Is there a way to check whether any of these crashes appear after it landed?

Comment 2

[David Teller [:Yoric] - still alive but not very active]

Apparently, these crashes still appear in recent builds, but much less often than before bug 1008944. I will request uplift.

Comment 3

[David Teller [:Yoric] - still alive but not very active]

Sorry, looking at the wrong crash. We seem to have *no* occurrences of this crash in recent builds. Requesting uplift.

Comment 4

[David Teller [:Yoric] - still alive but not very active]

http://yoric.github.io/are-we-shutting-down-yet-/#CrashMonitor:%20Writing%20notifications%20to%20file%20after%20receiving%20profile-before-change%20|%20OS.File:%20flush%20I/O%20queued%20before%20profile-before-change seems to confirm that we have no occurrence on recent builds.

Comment 5

[Sylvestre Ledru [:Sylvestre]]

From the comment, it seems to be fixed in 31. Updating the tracking flags accordingly.

Comment 6

[u279076]

I'm still seeing several crashes with Firefox 31.0, granted it's RC1 not RC2:
https://crash-stats.mozilla.com/report/index/120b44f3-a6d2-451e-b69b-487b72140716
https://crash-stats.mozilla.com/report/index/a39de730-eaae-4bea-89e8-f4bf02140716
https://crash-stats.mozilla.com/report/index/4d384eab-9904-4a07-aba8-555ea2140717
https://crash-stats.mozilla.com/report/index/f2858b50-70ed-44b6-821b-13c0c2140717
https://crash-stats.mozilla.com/report/index/ce860c03-d717-4b36-9d68-598412140717
https://crash-stats.mozilla.com/report/index/f26ae583-54ae-475e-87e2-973822140717
https://crash-stats.mozilla.com/report/index/72dc8a43-8b80-43a4-9872-838212140717
https://crash-stats.mozilla.com/report/index/217c717c-55c3-46ee-9514-bd67b2140717

Comment 7

[u279076]

Based on Yoric's report, this shows up 6% out of 1400 samples (~7148 total crashes over 7 days).

Source: http://yoric.github.io/are-we-shutting-down-yet-/#CrashMonitor:%20Writing%20notifications%20to%20file%20after%20receiving%20profile-before-change%20|%20OS.File:%20flush%20I/O%20queued%20before%20profile-before-change

Comment 8

[David Teller [:Yoric] - still alive but not very active]

Sorry, my comment was unclear. By "recent builds", I meant FF33.

Comment 9

[Lawrence Mandel [:lmandel] (use needinfo)]

This top crash has seen no recent activity. Perhaps that will change when Yoric is back. Marking ni on him to bring this to the top of his queue. I'm also marking this as won't fix in 32 as we're pretty much out of time.

Comment 10

[Lawrence Mandel [:lmandel] (use needinfo)]

Actually marking 32 this time. :)

Comment 11

[David Teller [:Yoric] - still alive but not very active]

My statistics are a bit blocked by bug 1039969. Taking a new look, though.

Comment 12

[David Teller [:Yoric] - still alive but not very active]

According to my statistics, this crash does not affect 32, 33 or 34 anymore. I'd like to mark this as fixed.

Comment 13

[u279076]

(In reply to David Rajchenbach-Teller [:Yoric] (use "needinfo") from comment #12)
> According to my statistics, this crash does not affect 32, 33 or 34 anymore.
> I'd like to mark this as fixed.

I concur. The stats seem to support the theory that this no longer affects Firefox/Thunderbird 32+. However, unless we know what patch fixed this bug, I would suggest it be marked RESOLVED WORKSFORME.

Comment 14

[David Teller [:Yoric] - still alive but not very active]

Sounds good.