1035006 - Clean up pyflakes warnings in Mozbase

Status: RESOLVED FIXED

(Testing :: Mozbase, defect)

Description

[Chris Manchester (limited bugmail, email directly)]

I have a patch running on try here: https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=34fe92434bcb

Comment 1

[Chris Manchester (limited bugmail, email directly)]

Attachment: Warnings before patch

Comment 2

[Chris Manchester (limited bugmail, email directly)]

Attachment: Warnings after patch

Comment 3

[Chris Manchester (limited bugmail, email directly)]

Attachment: Fix pyflakes warnings in mozbase.

Almost all unused imports or unused variables. Some false positives, some warnings that may indicate further dead code, in particular the uses of "sanitize_dependency" in setup_development.py, a function that was remove two years ago (bug 760722).

I'll request review if try looks ok.

Comment 4

[Chris Manchester (limited bugmail, email directly)]

Comment on attachment 8451396 [details] [diff] [review]
Fix pyflakes warnings in mozbase.

Try looks pretty ok (treeherder is showing a different set of tests than tbpl -- according to tbpl: https://tbpl.mozilla.org/?tree=Try&rev=5ae43e439b69, try looks pretty ok).

Comment 5

[William Lachance (:wlach)]

Comment on attachment 8451396 [details] [diff] [review]
Fix pyflakes warnings in mozbase.

Review of attachment 8451396 [details] [diff] [review]:
-----------------------------------------------------------------

Assuming everything passes try, this looks like a good set of cleanups. Thanks!

::: testing/mozbase/mozfile/mozfile/mozfile.py
@@ +265,5 @@
>          for resource in (dirnames, filenames):
>              resource[:] = sorted(resource, key=sort_key)
>  
>          files_end =  item_marker
> +        dirpath_mark = item_marker

I think you can just take these two lines out altogether. Seems like whoever wrote this function didn't understand python block scoping.

Comment 6

[Chris Manchester (limited bugmail, email directly)]

Attachment: Fix pyflakes warnings in mozbase.

Ok, this deletes those two lines.

Comment 7

[Chris Manchester (limited bugmail, email directly)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/9579d613f56a

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/9579d613f56a