Closed Bug 1035036 Opened 7 years ago Closed 7 years ago
Ctrl+clicking, shift-clicking, alt-clicking, meta-clicking a link selects a lot of things
Ctrl+clicking a link gives the same result as ctrl+clicking outside the link - selecting a lot of things around. I suspect it's a regression from bug 378775. Nightly regressed that day - version Firefox/33.0 ID:20140704030208 CSet: e8df6826a571 I'm on a notebook - don't know if makes any difference - don't have a mouse to test with. I'm filling this bug under Untriaged hoping someone else can reproduce and confirm that bug 378775 is the culprit.
Ctrl-clicking does <table> cell selection - after bug 378775 it happens for links in <table>s in addition to opening the link. The open-link-in-new-tab code should prevent the event from leaking.
Similarly, Shift+clicking a link selects a range of text in addition to opening the link in a new window.
It's worth noting that this doesn't just affect literal <table> elements, as it also happens for pages using CSS 'display: table-cell;' for styling.
Seeing this in OS X as well. [Cmd + click]
7 years ago
OS: Windows 7 → All
Hardware: x86_64 → All
Summary: Ctrl+clicking a link selects a lot of things → Ctrl+clicking, shift-clicking, alt-clicking, meta-clicking a link selects a lot of things
Kestrel, can you take this bug since your patch caused it?
Added exception for ctrl and shift modifiers so that opening links gets priority over selecting text.
Attachment #8458141 - Flags: review?(enndeakin)
It would be nice if we got a test for this as well, so that we don't regress it in the future.
You might want to check Cmd too, since on Mac it acts like Ctrl for the purposes of selection and link-dispatching.
Neil, any chance you could review this soon please? This bug is making using Nightly really painful for me... :(
Nevermind, it looks like the patch was backed out!
Comment on attachment 8458141 [details] [diff] [review] bug1035036.patch You will also want to check for IsMeta() as well.
Attachment #8458141 - Flags: review?(enndeakin) → review-
Kestrel, could you help here?
Solution was posted in bug 378775 using a different approach that delays selection.
Neil, could you point me where the backout has been done (Ehsan mentioned it in comment #14)? I would like to request the same for 33 (if this bug still occurs). I don't see the bug 378775 landing in 33. Thanks
This is a regression from bug 378775, of which I am only the reviewer.
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
(In reply to Sylvestre Ledru [:sylvestre] from comment #18) > Neil, could you point me where the backout has been done (Ehsan mentioned it > in comment #14)? I would like to request the same for 33 (if this bug still > occurs). > I don't see the bug 378775 landing in 33. > > Thanks It landed (and was backed out) prior to the previous uplift. https://bugzilla.mozilla.org/show_bug.cgi?id=378775#c49
You need to log in before you can comment on or make changes to this bug.