1035036 - Ctrl+clicking, shift-clicking, alt-clicking, meta-clicking a link selects a lot of things

Status: RESOLVED FIXED

(Core :: DOM: Selection, defect)

Description

[Guilherme Lima]

Attachment: Screenshot of the bug

Ctrl+clicking a link gives the same result as ctrl+clicking outside the link - selecting a lot of things around.

I suspect it's a regression from bug 378775.
Nightly regressed that day - version Firefox/33.0 ID:20140704030208 CSet: e8df6826a571

I'm on a notebook - don't know if makes any difference - don't have a mouse to test with.

I'm filling this bug under Untriaged hoping someone else can reproduce and confirm that bug 378775 is the culprit.

Comment 1

[Thomas Stache]

Ctrl-clicking does <table> cell selection - after bug 378775 it happens for links in <table>s in addition to opening the link. The open-link-in-new-tab code should prevent the event from leaking.

Comment 2

[Jesse Ruderman]

Similarly, Shift+clicking a link selects a range of text in addition to opening the link in a new window.

Comment 3

[Benjamin Kerensa [:bkerensa]]

Lets track this for now.

Comment 4

[Chris Siebenmann]

It's worth noting that this doesn't just affect literal <table>
elements, as it also happens for pages using CSS 'display: table-cell;'
for styling.

Comment 5

[matthias koplenig [:metasieben]]

Seeing this in OS X as well. [Cmd + click]

Comment 9

[Dão Gottwald [:dao]]

Kestrel, can you take this bug since your patch caused it?

Comment 10

[Kestrel]

Attachment: bug1035036.patch

Added exception for ctrl and shift modifiers so that opening links gets priority over selecting text.

Comment 11

[(no longer active)]

It would be nice if we got a test for this as well, so that we don't regress it in the future.

Comment 12

[Jesse Ruderman]

You might want to check Cmd too, since on Mac it acts like Ctrl for the purposes of selection and link-dispatching.

Comment 13

[(no longer active)]

Neil, any chance you could review this soon please?  This bug is making using Nightly really painful for me... :(

Comment 14

[(no longer active)]

Nevermind, it looks like the patch was backed out!

Comment 15

[Neil Deakin]

Comment on attachment 8458141 [details] [diff] [review]
bug1035036.patch

You will also want to check for IsMeta() as well.

Comment 16

[Sylvestre Ledru [:Sylvestre]]

Kestrel, could you help here?

Comment 17

[Kestrel]

Solution was posted in bug 378775 using a different approach that delays selection.

Comment 18

[Sylvestre Ledru [:Sylvestre]]

Neil, could you point me where the backout has been done (Ehsan mentioned it in comment #14)? I would like to request the same for 33 (if this bug still occurs).
I don't see the bug 378775 landing in 33.

Thanks

Comment 19

[Neil Deakin]

This is a regression from bug 378775, of which I am only the reviewer.

Comment 20

[Ryan VanderMeulen [:RyanVM]]

(In reply to Sylvestre Ledru [:sylvestre] from comment #18)
> Neil, could you point me where the backout has been done (Ehsan mentioned it
> in comment #14)? I would like to request the same for 33 (if this bug still
> occurs).
> I don't see the bug 378775 landing in 33.
> 
> Thanks

It landed (and was backed out) prior to the previous uplift.
https://bugzilla.mozilla.org/show_bug.cgi?id=378775#c49