1035092 - bool functions shouldn't return nullptr

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Octoploid]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:33.0) Gecko/20100101 Firefox/33.0 (Beta/Release)
Build ID: 20140703131445

Steps to reproduce:

Bug 1022773 changed the return type of several functions 
in jsapi.cpp from "JSScript *" to bool. But these function 
contain "return nullptr" statements, that are invalid according to:
http://www.open-std.org/jtc1/sc22/wg21/docs/cwg_defects.html#1423

Comment 1

[Steve Fink [:sfink] [:s:]]

Attachment: Fix places that return nullptr as a bool

Comment 2

[Steve Fink [:sfink] [:s:]]

Comment on attachment 8451667 [details] [diff] [review]
Fix places that return nullptr as a bool

Review of attachment 8451667 [details] [diff] [review]:
-----------------------------------------------------------------

I feel like I ought to spread out the reviews more, but I suppose you reviewed the original.

Comment 3

[Terrence Cole [:terrence]]

Comment on attachment 8451667 [details] [diff] [review]
Fix places that return nullptr as a bool

Review of attachment 8451667 [details] [diff] [review]:
-----------------------------------------------------------------

rs=me

Comment 4

[André Bargull [:anba]]

Btw, PossiblyFail() in jsgcinlines.h also returns nullptr instead of false.

Comment 5

[Steve Fink [:sfink] [:s:]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/0e0fbb8a815b

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/0e0fbb8a815b

Comment 7

[Steve Fink [:sfink] [:s:]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/0e0fbb8a815b

Comment 8

[Octoploid]

Attachment: bool.diff

Here are a couple of more fixes.

Comment 9

[Steve Fink [:sfink] [:s:]]

I just went ahead and pushed it. Thanks for the patch!

https://hg.mozilla.org/integration/mozilla-inbound/rev/9198564a941c

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/9198564a941c

Comment 11

[Steve Fink [:sfink] [:s:]]

There was a strange heisenbug that broke two mochitest devtools tests on this push. It has nothing to do with this patch. I've added info over at bug 876272.