1035136 - Intermittent Homescreen UI Tests failures: test_homescreen_launch_app.TestLaunchApp.test_launch_app

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::UI Tests, defect, P1)

Description

[[:AndreiH]]

https://travis-ci.org/mozilla-b2g/gaia/jobs/29247304
https://travis-ci.org/mozilla-b2g/gaia/jobs/29301254
https://travis-ci.org/mozilla-b2g/gaia/jobs/29296094
https://travis-ci.org/mozilla-b2g/gaia/jobs/29296049
https://travis-ci.org/mozilla-b2g/gaia/jobs/29295202
https://travis-ci.org/mozilla-b2g/gaia/jobs/29294429

It's our most frequent intermittent right now. It's not permafail but nearly...
Let's disable the test until we fix it.

Comment 1

[[:AndreiH]]

Attachment: PR https://github.com/mozilla-b2g/gaia/pull/21446

Comment 2

[Florin Strugariu [:Bebe]]

https://github.com/mozilla-b2g/gaia/commit/7f5637618c3e45434355ba04fcca4e7b944ff1ac

Comment 3

[[:AndreiH]]

I cannot reproduce this locally, but I am pretty sure that the notification is covering up the app while scrolling into view, so we can add a wait for the notification to not be displayed and see the results.

Comment 4

[Viorela Ioia [:viorela]]

I ran this test locally on desktop b2g and I was able to reproduce the failure. 
I watched the test while running and I noticed that the scroll is done before the notification dissapears, so the notification is covering the app, as stated in comment 3.
A wait for the notification not to be displayed  will be a good fix.

Comment 5

[[:AndreiH]]

Attachment: FIX PR https://github.com/mozilla-b2g/gaia/pull/21449

Comment 6

[Zac C (:zac)]

Comment on attachment 8452248 [details] [review]
FIX PR https://github.com/mozilla-b2g/gaia/pull/21449

r-, functionally fine just need to rename the variables.

Comment 7

[[:AndreiH]]

Comment on attachment 8452248 [details] [review]
FIX PR https://github.com/mozilla-b2g/gaia/pull/21449

Updated!

Comment 8

[Zac C (:zac)]

Comment on attachment 8452248 [details] [review]
FIX PR https://github.com/mozilla-b2g/gaia/pull/21449

r+ like!

Comment 9

[Zac C (:zac)]

Nice fix Andrei!

Merged:
https://github.com/mozilla-b2g/gaia/commit/210861212a1dbbf442442cfb3c99f3248d2fc5e5