Closed Bug 1035164 Opened 6 years ago Closed 6 years ago

Fix CUI to not call into ShortcutUtils and/or not log errors as badly in cases where there is no shortcut

Categories

(Firefox :: Toolbars and Customization, defect)

defect
Not set
Points:
1

Tracking

()

RESOLVED FIXED
Firefox 33
Iteration:
33.3

People

(Reporter: Gijs, Assigned: Gijs)

References

Details

Attachments

(1 file, 1 obsolete file)

STR:

1. Open Nightly
2. Open main menu panel
3. Open developer tools
4. Open browser toolbox

ER:
No errors/warnings

AR:

"[CustomizableUI]" "Could not find a keyboard shortcut for '<menuitem xmlns="http://www.mozilla.org/keymaster/gatekeeper/there.is.only.xul" id="menu_devAppMgr" observes="devtoolsMenuBroadcaster_DevAppMgr" accesskey="A" oncommand="gDevToolsBrowser.openAppManager(gBrowser);" label="App Manager" checked="false"/>'." CustomizableUI.jsm:158
"[CustomizableUI]" "Could not find a keyboard shortcut for '<menuitem xmlns="http://www.mozilla.org/keymaster/gatekeeper/there.is.only.xul" id="menu_browserToolbox" observes="devtoolsMenuBroadcaster_BrowserToolbox" accesskey="e" oncommand="BrowserToolboxProcess.init();" label="Browser Toolbox" checked="false"/>'." CustomizableUI.jsm:158
"[CustomizableUI]" "Could not find a keyboard shortcut for '<menuitem xmlns="http://www.mozilla.org/keymaster/gatekeeper/there.is.only.xul" id="menu_eyedropper" observes="devtoolsMenuBroadcaster_Eyedropper" accesskey="Y" oncommand="openEyedropper();" autocheck="false" type="checkbox" label="Eyedropper" checked="false"/>'." CustomizableUI.jsm:158
"[CustomizableUI]" "Could not find a keyboard shortcut for '<menuitem xmlns="http://www.mozilla.org/keymaster/gatekeeper/there.is.only.xul" id="menu_devtools_connect" observes="devtoolsMenuBroadcaster_connect" oncommand="gDevToolsBrowser.openConnectScreen(gBrowser)" label="Connect…" checked="false"/>'."

This is annoying. Let's not do this.
54           let shortcut = doc.getElementById(aAttrs.shortcutId);
55           if (doc) {
56             additionalArgs.push(ShortcutUtils.prettifyShortcut(shortcut));
57           }


D'oh.
Assignee: nobody → gijskruitbosch+bugs
Blocks: 940116
No longer blocks: 940038
Status: NEW → ASSIGNED
Attachment #8451632 - Flags: review?(jaws)
Except that the actual issue is elsewhere...
Attachment #8451635 - Flags: review?(jaws)
Attachment #8451632 - Attachment is obsolete: true
Attachment #8451632 - Flags: review?(jaws)
Comment on attachment 8451635 [details] [diff] [review]
fix nullcheck in CustomizableWidgets,

Review of attachment 8451635 [details] [diff] [review]:
-----------------------------------------------------------------

don't forget to update the commit message
Attachment #8451635 - Flags: review?(jaws) → review+
remote:   https://hg.mozilla.org/integration/fx-team/rev/ba1cb6bb143f

Marco: another one for 33.3... :-)
Iteration: --- → 33.3
Points: --- → 1
QA Whiteboard: [qa-]
Flags: needinfo?(mmucci)
Whiteboard: [fixed-in-fx-team]
Added to the priority list for Iteration 33.3
Flags: needinfo?(mmucci)
https://hg.mozilla.org/mozilla-central/rev/ba1cb6bb143f
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 33
Flags: firefox-backlog+
You need to log in before you can comment on or make changes to this bug.