1035221 - updated bless_groups throws a sql syntax error if visibility groups are used

Status: RESOLVED FIXED

(Bugzilla :: Bugzilla-General, defect)

Description

[:glob ✱]

(David Corry from Bug 993894 comment #8)
> This patch causes my Bugzilla installation to throw errors on every page
> unless the user is part of the editusers group.
> 
> >First error: undef error - DBD::mysql::db selectcol_arrayref failed: You have an error in your SQL syntax;
> >check the manual that corresponds to your MySQL server version for the right syntax to use near ')' at line 4 [for Statement "
> >       SELECT DISTINCT group_id
> >         FROM user_group_map
> >        WHERE user_id = ?
> >              AND isbless = 1 AND  group_id IN () "] at Bugzilla/User.pm line 1013>
> >Bugzilla::User::bless_groups('Bugzilla::User=HASH(0xa0eaff8)') called at Bugzilla/User.pm line 1712
> >Bugzilla::User::can_bless('Bugzilla::User=HASH(0xa0eaff8)') called at Bugzilla/User.pm line 1463
> >Bugzilla::User::can_administer('Bugzilla::User=HASH(0xa0eaff8)') called at template/en/default/global/common-links.html.tmpl line 58
> 
> (which continues on to all the template files.)
> 
> Reversing the patch fixes the errors.

Comment 1

[:glob ✱]

Attachment: 1035221_1.patch

Comment 2

[Simon Green]

Comment on attachment 8451660 [details] [diff] [review]
1035221_1.patch

I'm surprised this has never been picked up on brc. I guess everyone using the function has access to some groups.

Comment 3

[:glob ✱]

To ssh://[e-mail]/bugzilla/bugzilla.git
   eb527a5..171e504  master -> master