Closed
Bug 1035240
Opened 10 years ago
Closed 10 years ago
[Bluetooth] BluetoothSocket leaks file descriptor
Categories
(Firefox OS Graveyard :: Bluetooth, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
2.0 S6 (18july)
People
(Reporter: tzimmermann, Assigned: tzimmermann)
References
Details
Attachments
(1 file)
|
997 bytes,
patch
|
shawnjohnjr
:
review+
|
Details | Diff | Splinter Review |
On close operations, the BluetoothSocket for Bluedroid only removes the file descriptor from the I/O loop. The file descriptor is not being closed nor referenced any longer.
|
Assignee | |
Comment 1•10 years ago
|
||
Attachment #8451683 -
Flags: review?(shuang)
|
|
Assignee | |
Comment 2•10 years ago
|
||
It doesn't really depend on bug 1029387, but the patch won't apply cleanly without it.
Depends on: 1029387
Comment on attachment 8451683 [details] [diff] [review] [01] Bug 1035240: Close file descriptor in BluetoothSocket Review of attachment 8451683 [details] [diff] [review]: ----------------------------------------------------------------- It looks good to me.
Attachment #8451683 -
Flags: review?(shuang) → review+
|
|
Assignee | |
Comment 4•10 years ago
|
||
Thanks! https://hg.mozilla.org/integration/b2g-inbound/rev/08fe5757a75d https://tbpl.mozilla.org/?tree=B2g-Inbound&rev=08fe5757a75d
|
||
Comment 5•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/08fe5757a75d
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → 2.0 S6 (18july)
You need to log in
before you can comment on or make changes to this bug.
Description
•