bugzilla.mozilla.org has resumed normal operation. Attachments prior to 2014 will be unavailable for a few days. This is tracked in Bug 1475801.
Please report any other irregularities here.

Header text in AppChrome is misaligned

RESOLVED FIXED

Status

Firefox OS
Gaia::System
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: gmarty, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

46 bytes, text/x-github-pull-request
alive
: review+
Details | Review | Splinter Review
(Reporter)

Description

4 years ago
Open Facebook and log in.
Open an external link.
The header is not reiszed/aligned according to visual refresh.
(Reporter)

Comment 1

4 years ago
Created attachment 8451685 [details] [review]
Github PR

To fix this bug, I had to add font_size_utils to system. Maybe lazy loading from app_chrome.js would be a better way to do it.

Alive, what do you think of this patch?
Attachment #8451685 - Flags: review?(alive)
Comment on attachment 8451685 [details] [review]
Github PR

See my comment in github. Thank you!
Attachment #8451685 - Flags: review?(alive) → review+
(In reply to Alive Kuo [:alive][NEEDINFO!] from comment #2)
> Comment on attachment 8451685 [details] [review]
> Github PR
> 
> See my comment in github. Thank you!

My concern here:
We are having nested window now, so if popup opens popup, you will have multiple observer for the same header element if you are using |this.containerElement|

<div class="appWindow">
  <div class="appChrome">
    <header>
  <div class="popupWindow">
    <div class="appChrome">
      <header>

Let me know if you have concern to my proposal in github.
(Reporter)

Comment 4

4 years ago
Thanks Alive for that. I updated the code to reflect your comments on Github, it's all fine by me.
(Reporter)

Comment 5

4 years ago
Landed in:
https://github.com/mozilla-b2g/gaia/commit/9274e455c3c05469075560f9970106dfacac0512
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.