Closed Bug 1035243 Opened 10 years ago Closed 10 years ago

Header text in AppChrome is misaligned

Categories

(Firefox OS Graveyard :: Gaia::System, defect)

x86_64
Linux
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: gmarty, Unassigned)

Details

Attachments

(1 file)

46 bytes, text/x-github-pull-request
alive
: review+
Details | Review
Open Facebook and log in.
Open an external link.
The header is not reiszed/aligned according to visual refresh.
Attached file Github PR
To fix this bug, I had to add font_size_utils to system. Maybe lazy loading from app_chrome.js would be a better way to do it.

Alive, what do you think of this patch?
Attachment #8451685 - Flags: review?(alive)
Comment on attachment 8451685 [details] [review]
Github PR

See my comment in github. Thank you!
Attachment #8451685 - Flags: review?(alive) → review+
(In reply to Alive Kuo [:alive][NEEDINFO!] from comment #2)
> Comment on attachment 8451685 [details] [review]
> Github PR
> 
> See my comment in github. Thank you!

My concern here:
We are having nested window now, so if popup opens popup, you will have multiple observer for the same header element if you are using |this.containerElement|

<div class="appWindow">
  <div class="appChrome">
    <header>
  <div class="popupWindow">
    <div class="appChrome">
      <header>

Let me know if you have concern to my proposal in github.
Thanks Alive for that. I updated the code to reflect your comments on Github, it's all fine by me.
Landed in:
https://github.com/mozilla-b2g/gaia/commit/9274e455c3c05469075560f9970106dfacac0512
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: