1035261 - Overscrolling the home-screen doesn't transform the scroll indicator like it does elsewhere

Status: RESOLVED WORKSFORME

(Core :: Panning and Zooming, defect)

Description

[Chris Lord [:cwiiis]]

If you overscroll on the home-screen, the scroll indicator stays in the same place and doesn't indicate overscroll in any way.

This is contrary to the same thing in the Firefox Marketplace, for example, where the scroll indicator is transformed along with the page.

I don't feel strongly about either behaviour, but I feel we should be consistent.

Comment 1

[Kartikaya Gupta (email:[e-mail])]

This will probably be less noticeable with the new "stretch" overscroll but it's still something we should fix.

Comment 2

[Kartikaya Gupta (email:[e-mail])]

The two layer dumps where the shadow-transform on that layer changes from 1.49999 to 1.5 are probably the most interesting. There's a preScale that magically appears and the color layer changes in size. Somebody who knows about preScale should probably look at this *cough*matt*cough* :)

Comment 3

[Kartikaya Gupta (email:[e-mail])]

I looked into this briefly and the layer tree dumps for the marketplace are kind of surprising. While in overscroll there, the scrollbar doesn't show up as a separate layer at all, it seems to just get flattened into the content or something. While not in overscroll though it does appear as a separate layer. In the homescreen, by contrast, the scrollbar is always a separate layer. That might explain why the scrollbars transform with the content in the marketplace.

Comment 4

[Kartikaya Gupta (email:[e-mail])]

Attachment: Layer dumps from homescreen and marketplace w/ and w/o scrollbar layer

Comment 5

[Kartikaya Gupta (email:[e-mail])]

I just I posted comment 2 to the wrong bug, oops.

Comment 6

[Kartikaya Gupta (email:[e-mail])]

I tried this again on the latest code and now not only does everything seem to be layerized correctly, but also I can't reproduce the original problem. The overscroll transform seems to affect the scrollbar both on the homescreen and in the marketplace.

I tried backing out bug 1061327 locally to see if that was what fixed it but it wasn't. So I'm not sure what fixed it, but I can bisect if we want to uplift the fix. For now I'll just close this as WFM.

Comment 7

[Kartikaya Gupta (email:[e-mail])]

Ah, I think it might have been fixed by gaia-side changes in bug 1038178. Rolling back my gaia to a version just before that landed made the homescreen scrollbar remain unaffected by the overscroll stretch.

Comment 8

[Chris Lord [:cwiiis]]

(In reply to Kartikaya Gupta (email:[e-mail]) from comment #7)
> Ah, I think it might have been fixed by gaia-side changes in bug 1038178.
> Rolling back my gaia to a version just before that landed made the
> homescreen scrollbar remain unaffected by the overscroll stretch.

Yes, this would be it - I don't know if you want to re-title this bug to be about the more general case of overscroll on sub-frames, but I don't think it's important.

Comment 9

[Kartikaya Gupta (email:[e-mail])]

The part 2 patch on bug 1043859 makes all root-level scrollbars be unaffected by overscroll as well. That makes them consistent with subframe scrollbars. That's easier (and more future-compatible) than giving them all overscroll.