Closed
Bug 1035300
Opened 11 years ago
Closed 11 years ago
css coverage report shows incorrect data when run with oneshot
Categories
(DevTools :: Style Editor, defect)
DevTools
Style Editor
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 33
People
(Reporter: jwalker, Assigned: jwalker, Mentored)
References
Details
Attachments
(1 file)
|
2.94 KB,
patch
|
harth
:
review+
|
Details | Diff | Splinter Review |
No description provided.
|
Assignee | |
Updated•11 years ago
|
Blocks: enable-csscoverage
|
|
Assignee | |
Comment 1•11 years ago
|
||
The "csscoverage oneshot" command in /toolkit/devtools/gcli/commands/csscoverage.js isn't going to be exposes in the main UI, and it's not the end of the world if we leave it hidden.
The CSSUsageActor (/toolkit/devtools/server/actors/csscoverage.js) should mark itself (this._isOneShot=true or similar) if its data was created using "oneshot" and if createPageReport is called in oneshot mode, we should throw.
Finally the "csscoverage report" command should make sure it displays a suitable error message.
Mentor: jwalker
Whiteboard: [good first bug][lang=js]
|
|
Assignee | |
Comment 2•11 years ago
|
||
Links to help you get started:
* https://wiki.mozilla.org/DevTools
* https://wiki.mozilla.org/DevTools/GetInvolved
* https://wiki.mozilla.org/DevTools/Hacking
|
|
Assignee | |
Comment 3•11 years ago
|
||
|
||
Updated•11 years ago
|
Attachment #8454456 -
Flags: review?(fayearthur) → review+
|
|
Assignee | |
Updated•11 years ago
|
Keywords: checkin-needed
Whiteboard: [good first bug][lang=js]
|
||
Comment 4•11 years ago
|
||
Keywords: checkin-needed
Whiteboard: [fixed-in-fx-team]
|
||
Comment 5•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 33
|
||
Updated•7 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•