1035383 - [B2G][Camera] The user is able to use the camera when battery is below 5%

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Camera, defect)

Description

[Derek Harris [:DerekH] - Dont need info. Last day 6/5/15]

Attachment: Battery Life.txt

Description:
The user is able to use the camera no matter how much battery life is left on the phone

Prerequsite: DUT has less than 5% battery life

Repro Steps:
1) Update a Flame to Build ID: 20140707000200
2) Open Camera app

Actual:
No warning saying "The battery is too low to use the camera." appears

Expected:
The user is unable to use the camera and "The battery is too low to use the camera." warning message appears

Flame 2.0

Environmental Variables:
Device: Flame 2.0
Build ID: 20140707000200
Gaia: ef67af27dff3130d41a9139d6ae7ed640c34d922
Gecko: f53099796238
Version: 32.0a2 (2.0) 
Firmware Version: v122
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0

Keywords: Battery, Percentage, Low, Less than, Below, Camera, Video, Media

Repro frequency: 100%
Link to failed test case: https://moztrap.mozilla.org/manage/case/12703/
See attached: Logcat, Video - http://youtu.be/Ctf4INrq0Sc

Comment 1

[Derek Harris [:DerekH] - Dont need info. Last day 6/5/15]

This issue DOES occur on Flame 2.1, and Buri 2.1

Flame 2.1

Environmental Variables:
Device: Flame Master
Build ID: 20140707040201
Gaia: 93daa354671a698634a3dc661c8c9dcb7d824c31
Gecko: 1dc6b294800d
Version: 33.0a1 (Master) 
Firmware Version: v122
User Agent: Mozilla/5.0 (Mobile; rv:33.0) Gecko/33.0 Firefox/33.0

Buri 2.1

Environmental Variables:
Device: Buri 2.1
Build ID: 20140707040201
Gaia: 93daa354671a698634a3dc661c8c9dcb7d824c31
Gecko: 1dc6b294800d
Version: 33.0a1  
Firmware Version: v1.2device.cfg

User agent: Mozilla/5.0 (Mobile; rv:33.0) Gecko/33.0 Firefox/33.0

This issue does NOT occur on Flame 1.4, or Buri 1.4

Flame 1.4

Environmental Variables:
Device: Flame 1.4
Build ID: 20140707000200
Gaia: 5c9e1e4131d3ac8915ed88b72bb66dc7d97be6a0
Gecko: 2d0c15450488
Version: 30.0 (1.4) 
Firmware Version: v122
User Agent: Mozilla/5.0 (Mobile; rv:30.0) Gecko/30.0 Firefox/30.0 

Buri 1.4

Environmental Variables:
Device: Buri 1.4
Build ID: 20140707000200
Gaia: 5c9e1e4131d3ac8915ed88b72bb66dc7d97be6a0
Gecko: 2d0c15450488
Version: 30.0 (1.4) 
Firmware Version: v1.2device.cfg
User Agent: Mozilla/5.0 (Mobile; rv:30.0) Gecko/30.0 Firefox/30.0

Comment 2

[Derek Harris [:DerekH] - Dont need info. Last day 6/5/15]

The warning message saying "10% battery remaining" when opening the camera app at 10% battery life does not show up either. Only an icon with a battery at low life appears on the left side of the screen

Comment 3

[KTucker [:KTucker][Inactive 3/4/2016]]

Nominating this 2.0? since this a regression from 1.4. This could lead to end user frustration when their battery dies while recording a video. 

These scenarios were stated in Bug 966841 which was resolved fixed.

Comment 4

[Hema Koka [:hema]]

Diego/Wilson - Can one of you help investigate this one?

Comment 5

[Diego Marcos [:dmarcos]]

Everything is wired up properly and we actually attempt to display the low battery message that would prevent the user to operate the camera. We have an orchestration problem. This is why the message is not showing up:

1. To speedup camera startup (tap to photo time) we're lazy loading some of the modules. i10n and the battery module are among them.
2. The battery module properly triggers an event that indicates very low battery at camera startup
3. The event is received by the overlay module to display the appropriate message.
4. Overlay fails to display the message because i10n module is not loaded. 

First approach to a solution (PR attached):

1. I load i10n module before the battery module.
2. When battery triggers its event the i10n is ready and the low battery message is rendered.

Problems: 

1. i10n has itself parts that are asynchronously loaded. Loading i10n before battery does not guarantee that the module is going to be ready when overlay needs to display a message.
2. By lazy loading battery and i10n modules we are delaying the battery level check until the preview is ready. In slow phones (like Hamachi) the camera is usable for several seconds before displaying the low battery message. This results on the user being able to take pictures or videos in low battery conditions.

We need to find a way to orchestrate the initialization without affecting the critical path.

Comment 6

[Diego Marcos [:dmarcos]]

Attachment: Pull Request

Comment 7

[Diego Marcos [:dmarcos]]

The PR is not meant to be merged. It just illustrates the problem.

Comment 8

[Hema Koka [:hema]]

Regression from 1.4 and if battery low warning is not seen, user will certainly be frustrating when shooting important videos. The message lets the user power up the device.

Comment 9

[Diego Marcos [:dmarcos]]

Comment on attachment 8452789 [details] [review]
Pull Request

New PR. Still not ready but making progress towards the solution:

- Battery module is part of the critical path so we can show the overlay as fast as possible.
- It displays a spinner before i10n is ready to prevent the user operate the camera.
- We display the localized overlay once i10n is ready. On hamachi i10n takes > 1 seconds to emit the localized event. 

The PR emulates low battery conditions and there's logging to measure i10n loading times (adb logcat | grep i10n)

Comment 10

[Wilson Page [:wilsonpage]]

Comment on attachment 8452789 [details] [review]
Pull Request

Overall looks good!

- Some code comments left in Github.
- Unrelated, but there is a quick flicker before the overlay background loads in. Ideally we should use CSS gradients for this and ditch the PNGs. Or alternatively if there is a way to preload the PNG, that might help. Any ideas? It looks pretty shitty ATM.

Comment 11

[Justin D'Arcangelo [:justindarc]]

Comment on attachment 8452789 [details] [review]
Pull Request

looks good! land it!

Comment 12

[Diego Marcos [:dmarcos]]

Landed on master:

https://github.com/mozilla-b2g/gaia/commit/913056a1580bb802d5bf6efe2fa0fdf206ba67c0

Comment 13

[Ryan VanderMeulen [:RyanVM]]

v2.0: https://github.com/mozilla-b2g/gaia/commit/750688b7951ca1ceb216806224d9b0a8463dd8a8

Comment 14

[Joshua Mitchell (Inactive)]

issue was fixed before anyone got to the regression-window, removing that tag now.

Comment 15

[Shine(Leave from Mozilla)]

Attachment: video

This issue has been verified successfully on Flame 2.0 and 2.1.
When device has 5% battery life or less than 5% battery life, launch camera, the "The battery is too low to use the camera.” warning message can appears
See attachment: Verify_1035383.MP4
Reproducing rate: 0/5

Flame2.0 build:
Gaia-Rev        856863962362030174bae4e03d59c3ebbc182473
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g32_v2_0/rev/e40fe21e37f1
Build-ID        20141207000206
Version         32.0

Flame2.1 build:
Gaia-Rev        38e17b0219cbc50a4ad6f51101898f89e513a552
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/8b92c4b8f59a
Build-ID        20141205001201
Version         34.0