add detail feed view to transonic previews

RESOLVED FIXED

Status

P5
normal
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: krupa.mozbugs, Assigned: spasovski)

Tracking

x86
macOS
Points:
---

Details

(URL)

Attachments

(1 attachment)

(Reporter)

Description

5 years ago
Created attachment 8451938 [details]
feed preview missing apps.png

steps to reproduce:
1. Load https://marketplace-dev.allizom.org/curate/manage/shelves/felwjkb
2. Notice the feed preview
3. Add a few apps and see if the preview updates


observed behavior:
Feed preview for operator shelves doesn't show the listed apps. See screenshot.
Assignee: nobody → kngo
Priority: -- → P2
Operator shelves never show their constituent apps on the feed, and the preview currently only shows the feed representation of a feed item, not the detail.

That said, we probably should be showing both. Davor, thoughts on that?
Flags: needinfo?(dspasovski)
It's been a TODO.

Updated

5 years ago
Assignee: kngo → nobody
Flags: needinfo?(dspasovski)
Summary: Feed preview for operator shelves is missing apps → add detail feed view to transonic previews
I don't think I have the "bandwidth" for this, and Chuck is on PTO.
Assignee: nobody → dspasovski
For implementation, I would move the feed detail view templates in Fireplace to feed_item.html. Pass the feed macros a "landing=True" flag. If that flag is set, have it include another macro that contains detail view specific stuff.
Priority: P2 → P5
Blocks: 1033040
No longer blocks: 1032972
(Assignee)

Comment 5

5 years ago
https://github.com/mozilla/transonic/commit/02e5239b0d5d8adeb2335f54f7b1f3468028f6d0
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.