Closed Bug 1035508 Opened 5 years ago Closed 5 years ago

"mach jetpack-test" doesn't run any tests

Categories

(Add-on SDK Graveyard :: General, defect, P1)

x86
macOS
defect

Tracking

(Not tracked)

RESOLVED FIXED
mozilla33

People

(Reporter: mossop, Assigned: mossop)

References

Details

Attachments

(1 file)

Launches Firefox but says "No tests were run" :(

Might be a simple fix in the mach command file, might need to wait for mochitestification.
Assignee: nobody → dtownsend+bugmail
Depends on: 1031328
Blocks: 1020473
Attached patch patchSplinter Review
Bug 1031328 means we have to be in the right directory when we run the tests. Probably easier to fix it here than there since we're looking into replacing our test harness.
Attachment #8452708 - Flags: review?(gps)
Comment on attachment 8452708 [details] [diff] [review]
patch

Review of attachment 8452708 [details] [diff] [review]:
-----------------------------------------------------------------

::: testing/testsuite-targets.mk
@@ +378,5 @@
>            echo 'please prepare your host with environment variables for TEST_DEVICE'; \
>          fi
>  
>  jetpack-tests:
> +	cd $(topsrcdir)/addon-sdk/source && $(PYTHON) bin/cfx -b $(realpath $(browser_path)) --parseable testpkgs

$(abspath) is a better choice here. $(realpath) does symlink expansion, etc. You don't typically use $(realpath) unless you are testing whether two paths are the same.
Attachment #8452708 - Flags: review?(gps) → review+
Priority: -- → P1
https://hg.mozilla.org/mozilla-central/rev/2ee48404d403
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla33
You need to log in before you can comment on or make changes to this bug.