1035508 - "mach jetpack-test" doesn't run any tests

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: General, defect, P1)

Description

[Dave Townsend [:mossop]]

Launches Firefox but says "No tests were run" :(

Might be a simple fix in the mach command file, might need to wait for mochitestification.

Comment 1

[Dave Townsend [:mossop]]

Attachment: patch

Bug 1031328 means we have to be in the right directory when we run the tests. Probably easier to fix it here than there since we're looking into replacing our test harness.

Comment 2

[Gregory Szorc [:gps]]

Comment on attachment 8452708 [details] [diff] [review]
patch

Review of attachment 8452708 [details] [diff] [review]:
-----------------------------------------------------------------

::: testing/testsuite-targets.mk
@@ +378,5 @@
>            echo 'please prepare your host with environment variables for TEST_DEVICE'; \
>          fi
>  
>  jetpack-tests:
> +	cd $(topsrcdir)/addon-sdk/source && $(PYTHON) bin/cfx -b $(realpath $(browser_path)) --parseable testpkgs

$(abspath) is a better choice here. $(realpath) does symlink expansion, etc. You don't typically use $(realpath) unless you are testing whether two paths are the same.

Comment 3

[Dave Townsend [:mossop]]

https://hg.mozilla.org/integration/fx-team/rev/2ee48404d403

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/2ee48404d403