Closed
Bug 1035551
Opened 10 years ago
Closed 10 years ago
Add in_tree_config support for Marionette
Categories
(Remote Protocol :: Marionette, defect)
Remote Protocol
Marionette
Tracking
(firefox30 wontfix, firefox31 fixed, firefox32 fixed, firefox33 fixed, firefox-esr24 fixed, firefox-esr31 fixed, b2g-v1.3 fixed, b2g-v1.3T fixed, b2g-v1.4 fixed, b2g-v2.0 fixed, b2g-v2.1 fixed)
RESOLVED
FIXED
mozilla33
People
(Reporter: gps, Assigned: chmanchester)
References
Details
(Whiteboard: [leave-open])
Attachments
(3 files, 3 obsolete files)
2.31 KB,
patch
|
ahal
:
review+
|
Details | Diff | Splinter Review |
2.13 KB,
patch
|
chmanchester
:
review+
|
Details | Diff | Splinter Review |
11.44 KB,
patch
|
chmanchester
:
review+
|
Details | Diff | Splinter Review |
The mozharness Marionette configs don't currently define in_tree_config. We need this to help roll out bug 940954.
Reporter | ||
Comment 1•10 years ago
|
||
We'll be adding a new argument to the Marionette CLI driver in bug 940954. We'll need to have mozharness pass this argument to get tests to work properly. To facilitate this, we're adding an in-tree Marionette config that will add this argument. Reviewer Note: I'm not sure if I changed too many or too few of the Marionette config files to now include an in-tree config. Also, I'm pretty sure mozharness fails if the in-tree config file isn't present. So I guess I need to add an empty file to all the trees? As much as I wanted to use the existing mac_config.py, linux_config.py, etc config files, marionette seems to share config files between platforms. I'm not sure if I should be doing os.platform() foo inside the config file or what. That's what review is for!
Attachment #8452776 -
Flags: review?(jgriffin)
Reporter | ||
Updated•10 years ago
|
Assignee: nobody → gps
Status: NEW → ASSIGNED
Comment 2•10 years ago
|
||
Comment on attachment 8452776 [details] [diff] [review] Support in-tree configs for Marionette Review of attachment 8452776 [details] [diff] [review]: ----------------------------------------------------------------- lgtm
Attachment #8452776 -
Flags: review?(jgriffin) → review+
Reporter | ||
Comment 4•10 years ago
|
||
Chris: If you want to steal this from me, go right ahead. I'll be side-tracked for the next few days dealing with Firefox foo.
Assignee | ||
Updated•10 years ago
|
Assignee: gps → cmanchester
Comment 5•10 years ago
|
||
Chris, you'll still need to pull the command line arguments out of marionette.py and into the config. Also, all the other harness' in-tree configs live under testing/config/mozharness, can we put this file alongside those?
Assignee | ||
Comment 6•10 years ago
|
||
This is looking good on ash.
Attachment #8454559 -
Flags: review?(ahalberstadt)
Assignee | ||
Comment 7•10 years ago
|
||
This is the config file to be used.
Attachment #8455411 -
Flags: review?(ahalberstadt)
Assignee | ||
Updated•10 years ago
|
Attachment #8454559 -
Attachment is obsolete: true
Attachment #8454559 -
Flags: review?(ahalberstadt)
Assignee | ||
Comment 8•10 years ago
|
||
These are the modifications to the mozharness script to read the in-tree config.
Attachment #8455413 -
Flags: review?(ahalberstadt)
Comment 9•10 years ago
|
||
Comment on attachment 8455411 [details] [diff] [review] Add an in-tree config for marionette tests. Review of attachment 8455411 [details] [diff] [review]: ----------------------------------------------------------------- Looks good!
Attachment #8455411 -
Flags: review?(ahalberstadt) → review+
Comment 10•10 years ago
|
||
Comment on attachment 8455413 [details] [diff] [review] Add support for in tree configs in mozharness in marionette.py script. Review of attachment 8455413 [details] [diff] [review]: ----------------------------------------------------------------- Nice, thanks! So I see you are going the 'land on every tree' route. I agree this is a good idea since this time all you are doing is adding a file that should get automatically copied over since the ground work was already laid out by bug 981030. If you ask one of the sheriffs nicely, they might be able to help you uplift to all of the older branches since they do uplifts there once in awhile anyway. Failing that, I can help you do it. One thing to note, people who haven't re-based their Mn try runs will hit a failure. Luckily from last time an appropriate error message should already get printed if this happens: http://mxr.mozilla.org/build/source/mozharness/mozharness/mozilla/testing/testbase.py#327 We'll just want to update the referenced bug to note that Mn was recently changed.
Attachment #8455413 -
Flags: review?(ahalberstadt) → review+
Assignee | ||
Comment 11•10 years ago
|
||
Here's a version of the config suitable for all branches (doesn't add the "--log-raw" option). r=ahal
Assignee | ||
Comment 12•10 years ago
|
||
As we did in bug 981030, we need to land the new config on every tree so that the mozharness change doesn't cause bustage. ahal recommended I alert a sheriff to see about how to do this. The attachment in comment 11 is intended to land on all the trees. Ryan, what do you think?
Flags: needinfo?(ryanvm)
Assignee | ||
Comment 13•10 years ago
|
||
Config for central landed: https://hg.mozilla.org/integration/mozilla-inbound/rev/3053c94b3215
Updated•10 years ago
|
Flags: needinfo?(ryanvm)
Assignee | ||
Updated•10 years ago
|
Attachment #8452776 -
Attachment is obsolete: true
Assignee | ||
Updated•10 years ago
|
Attachment #8455507 -
Flags: review+
Assignee | ||
Comment 14•10 years ago
|
||
Updated error message to point to this bug. r=ahal
Assignee | ||
Updated•10 years ago
|
Attachment #8455413 -
Attachment is obsolete: true
Assignee | ||
Updated•10 years ago
|
Attachment #8455604 -
Flags: review+
Comment 15•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/3053c94b3215
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla33
Updated•10 years ago
|
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Whiteboard: [leave-open]
Assignee | ||
Comment 16•10 years ago
|
||
This has been on central about a day, let's get the ball rolling. Ryan, could you land the patch from comment 11 on all trees when you have an opportunity?
Flags: needinfo?(ryanvm)
Comment 17•10 years ago
|
||
https://hg.mozilla.org/releases/mozilla-aurora/rev/dab59c1307c4 https://hg.mozilla.org/releases/mozilla-release/rev/650879b8b29d https://hg.mozilla.org/releases/mozilla-esr31/rev/02284260fbb4 https://hg.mozilla.org/releases/mozilla-b2g30_v1_4/rev/074223c547af https://hg.mozilla.org/releases/mozilla-b2g28_v1_3/rev/88fc67bb7d2b https://hg.mozilla.org/releases/mozilla-esr24/rev/785034ef8ed5
status-b2g-v1.3:
--- → fixed
status-b2g-v1.3T:
--- → fixed
status-b2g-v1.4:
--- → fixed
status-b2g-v2.0:
--- → fixed
status-b2g-v2.1:
--- → fixed
status-firefox30:
--- → wontfix
status-firefox31:
--- → fixed
status-firefox32:
--- → fixed
status-firefox33:
--- → fixed
status-firefox-esr24:
--- → fixed
status-firefox-esr31:
--- → fixed
Flags: needinfo?(ryanvm)
Assignee | ||
Comment 18•10 years ago
|
||
(In reply to Ryan VanderMeulen [:RyanVM UTC-4] from comment #17) > https://hg.mozilla.org/releases/mozilla-aurora/rev/dab59c1307c4 > https://hg.mozilla.org/releases/mozilla-release/rev/650879b8b29d > https://hg.mozilla.org/releases/mozilla-esr31/rev/02284260fbb4 > https://hg.mozilla.org/releases/mozilla-b2g30_v1_4/rev/074223c547af > https://hg.mozilla.org/releases/mozilla-b2g28_v1_3/rev/88fc67bb7d2b > https://hg.mozilla.org/releases/mozilla-esr24/rev/785034ef8ed5 This is the config with the new option for logging, so will cause bustage once we land the mozharness changes. We need the config from comment 11 without this option, not the one checked into central: https://bug1035551.bugzilla.mozilla.org/attachment.cgi?id=8455507 I know this is a hassle, sorry for the confusion here!
Flags: needinfo?(ryanvm)
Comment 19•10 years ago
|
||
https://hg.mozilla.org/releases/mozilla-aurora/rev/4c74eca8112f https://hg.mozilla.org/releases/mozilla-release/rev/a1a032b080d3 https://hg.mozilla.org/releases/mozilla-esr31/rev/8879005f2bd6 https://hg.mozilla.org/releases/mozilla-b2g30_v1_4/rev/68a2a43dff5b https://hg.mozilla.org/releases/mozilla-b2g28_v1_3/rev/a7dd18f55543 https://hg.mozilla.org/releases/mozilla-esr24/rev/31c2006018e1
Flags: needinfo?(ryanvm)
Assignee | ||
Comment 20•10 years ago
|
||
Mozharness changes: https://hg.mozilla.org/build/mozharness/rev/589cda99ef76
Comment 21•10 years ago
|
||
Here is a green cypress run with the above patch included: https://tbpl.mozilla.org/?tree=Cypress&jobname=marionette&rev=0dc711216018
Assignee | ||
Comment 22•10 years ago
|
||
Looks like this hit production here: http://hg.mozilla.org/build/mozharness/rev/1c4d5ded5f51
Assignee | ||
Comment 23•10 years ago
|
||
Re-triggers from this morning on the older trees look ok, except for release where there isn't anything recent enough on release I can re-trigger with all the changes picked up.
Assignee | ||
Updated•10 years ago
|
Status: REOPENED → RESOLVED
Closed: 10 years ago → 10 years ago
Resolution: --- → FIXED
Updated•1 year ago
|
Product: Testing → Remote Protocol
You need to log in
before you can comment on or make changes to this bug.
Description
•