Closed
Bug 1035590
Opened 10 years ago
Closed 10 years ago
Don't share python virtualenv between c-c and m-c.
Categories
(MailNews Core :: Build Config, defect)
MailNews Core
Build Config
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 33.0
People
(Reporter: glandium, Assigned: glandium)
References
Details
Attachments
(1 file)
918 bytes,
patch
|
jcranmer
:
review+
|
Details | Diff | Splinter Review |
One of the reasons the build is confused by objdir paths is that the mozconfig reading code implies things from a mozinfo.json file in the directory above where the virtualenv is. I originally went for moving the virtualenv to c-c's objdir, but that might as well subtly break the m-c objdir... Let's just simplify the problem and not install a common virtualenv.
Assignee | ||
Comment 1•10 years ago
|
||
Attachment #8452095 -
Flags: review?(Pidgeot18)
Comment 2•10 years ago
|
||
Comment on attachment 8452095 [details] [diff] [review] Don't share python virtualenv between c-c and m-c Review of attachment 8452095 [details] [diff] [review]: ----------------------------------------------------------------- Slightly disheartening, but this sounds like the least bad solution.
Attachment #8452095 -
Flags: review?(Pidgeot18) → review+
Assignee | ||
Comment 3•10 years ago
|
||
https://hg.mozilla.org/comm-central/rev/30a1a691d88a
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 33.0
You need to log in
before you can comment on or make changes to this bug.
Description
•