[Bluetooth] - check missing images

RESOLVED FIXED

Status

Firefox OS
Gaia::Bluetooth
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: ivanovpavel, Assigned: ivanovpavel)

Tracking

(Blocks: 1 bug)

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

46 bytes, text/x-github-pull-request
iliu@mozilla.com, ianliu.moz@gmail.com
: review+
Details | Review | Splinter Review
Comment hidden (empty)
We need to check following images:

apps/bluetooth/style/images/document_bg@1.5x.png
apps/bluetooth/style/images/document_bg@2x.png
apps/bluetooth/style/images/document_bg@2.25x.png
Summary: [Bluetooth] - remove unused images → [Bluetooth] - check missing images
Hey Fang,
I find all other version (@1x, @1.5x, @2x) and I just want to export @2.25x
Can you help me to find the @2.25x version of noised background in Settings App?

Thanks in advance :)
Flags: needinfo?(fshih)
Created attachment 8460511 [details] [review]
patch for Gaia/master
Hi Pavel, looks like the background was changed in solid style in Settings app before. Bluetooth app have to sync the style with settings app. Because we use the same style from settings::bluetooth::"devices in the area". For the bug here, we should replace "document_bg.png" with CSS style. So that we don't need the lager scaled images for it. Also clear ni. from Fang. Thanks.

Please reference the patch: https://github.com/mozilla-b2g/gaia/commit/23122c73dea5dcb2fdc2148e2d3126ebca30023a
Flags: needinfo?(fshih)
Comment on attachment 8460511 [details] [review]
patch for Gaia/master

Hey Ian,

Thanks for the info :)
Attachment #8460511 - Flags: review?(iliu)
Comment on attachment 8460511 [details] [review]
patch for Gaia/master

Looks good for me:) Thanks for your help.
Attachment #8460511 - Flags: review?(iliu) → review+
Sure, Thanks :)

Landed to master:
https://github.com/mozilla-b2g/gaia/commit/5fab48d60df4d2ad44e7c3be2fc8321a67819a87
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.