Closed Bug 1035664 Opened 10 years ago Closed 10 years ago

[Camera] - check missing images

Categories

(Firefox OS Graveyard :: Gaia::Camera, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Camera
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: pivanov, Assigned: pivanov)

References

Details

Attachments

(1 file)

patch for Gaia/master
46 bytes, text/x-github-pull-request
justindarc
: review+
Details | Review 
We need to check following images:

apps/camera/style/images/ui/gradient@2x.png
apps/camera/style/images/ui/gradient@2.25x.png
apps/camera/style/images/ui/pattern@2x.png
apps/camera/style/images/ui/pattern@2.25x.png
Summary: [Camera] - remove unused images → [Camera] - check missing images
Attached file patch for Gaia/master — 

        Attachment #8472877 -
        Flags: review?(pdahiya)

    
    

    
  
Comment on attachment 8472877 [details] [review]
patch for Gaia/master

Hi Pavel
I noticed updated gradient.png and its @1.5x version has increased in size from its previous version. Please check if it can be reduced to previous sizes.

Setting review flag for Justin to keep camera peer in loop about this change. Thanks

        Attachment #8472877 -
        Flags: review?(pdahiya) → review?(jdarcangelo)

    
    

    
  
Hey Punam,

the size is changed like in all other apps and I compressed the images with `png_recompress.sh`
Flags: needinfo?(pdahiya)

    
    

    
  
(In reply to Pavel Ivanov [:ivanovpavel] from comment #3)
> Hey Punam,
> 
> the size is changed like in all other apps and I compressed the images with
> `png_recompress.sh`

Thanks Pavel for looking into it.
Flags: needinfo?(pdahiya)

    
    

    
  
Comment on attachment 8472877 [details] [review]
patch for Gaia/master

LGTM, thanks!

        Attachment #8472877 -
        Flags: review?(jdarcangelo) → review+

    
    

    
  
Thanks :)

Landed to master:
https://github.com/mozilla-b2g/gaia/commit/1d6f971ae185bc7b376920657e76ff4d30da2ec6
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: