[Costcontrol] - check missing images

RESOLVED FIXED

Status

Product:
Firefox OS Graveyard
Component:
Gaia::Cost Control
Status:
RESOLVED FIXED
Reported:
4 years ago
Modified:
4 years ago

People

(Reporter: pivanov, Assigned: pivanov)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

CostControl.zip
31.93 KB, application/zip
Details
patch for Gaia/master
46 bytes, text/x-github-pull-request
salva
: review+
HHuang
: ui-review+
Details | Review | Splinter Review
(Assignee)

Description

•
4 years ago 
We need to check following images:

apps/costcontrol/style/images/app/ui/datausage/pattern-3g@2x.png
apps/costcontrol/style/images/app/ui/datausage/pattern-3g@2.25x.png
apps/costcontrol/style/images/app/ui/datausage/pattern@1.5x.png
apps/costcontrol/style/images/app/ui/datausage/pattern@2x.png
apps/costcontrol/style/images/app/ui/datausage/pattern@2.25x.png
??? apps/costcontrol/style/images/app/ui/datausage/toggle-bg@1.5x.png
??? apps/costcontrol/style/images/app/ui/datausage/toggle-bg@2x.png
??? apps/costcontrol/style/images/app/ui/datausage/toggle-bg@2.25x.png
apps/costcontrol/style/images/app/ui/pattern@1.5x.png
apps/costcontrol/style/images/app/ui/pattern@2x.png
apps/costcontrol/style/images/app/ui/pattern@2.25x.png
apps/costcontrol/style/images/widget/ui/glossy-gradient@1.5x.png
apps/costcontrol/style/images/widget/ui/glossy-gradient@2x.png
apps/costcontrol/style/images/widget/ui/glossy-gradient@2.25x.png
??? apps/costcontrol/style/images/widget/ui/no-credit-pattern@1.5x.png
??? apps/costcontrol/style/images/widget/ui/no-credit-pattern@2x.png
??? apps/costcontrol/style/images/widget/ui/no-credit-pattern@2.25x.png
apps/costcontrol/style/images/widget/ui/pattern-progress@1.5x.png
apps/costcontrol/style/images/widget/ui/pattern-progress@2x.png
apps/costcontrol/style/images/widget/ui/pattern-progress@2.25x.png
apps/costcontrol/style/images/widget/ui/zero-credit@1.5x.png
apps/costcontrol/style/images/widget/ui/zero-credit@2x.png
apps/costcontrol/style/images/widget/ui/zero-credit@2.25x.png

??? - we need to double check this
Summary: [Costcontrol] - remove unused images → [Costcontrol] - check missing images
 (Assignee)

Comment 1

•
4 years ago 
Hey Stephany,

do you know who can help with this images?
Flags: needinfo?(swilkes)

Comment 2

•
4 years ago 
Patryk or Mike, do you know anyone from visual design who may be able to assist Pavel with missing images (again!)? Thank you!
Flags: needinfo?(swilkes)
Flags: needinfo?(padamczyk)
Flags: needinfo?(mtsai)

Comment 3

•
4 years ago 
Helen is willing to help, although she is not the designer for Cost Control but she can help to find the missing images from massive file database. Thank you, Helen.
Flags: needinfo?(mtsai) → needinfo?(hhuang)
Flags: needinfo?(padamczyk)

Comment 4

•
4 years ago 
Created attachment 8478188 [details]
CostControl.zip

Hi Pavel, the images are ready, please help to update them, thanks!
Flags: needinfo?(hhuang)
 (Assignee)

Comment 5

•
4 years ago 
Created attachment 8478215 [details] [review]
patch for Gaia/master

Thanks :)

Can you ui-r?
Attachment #8478215 - Flags: ui-review?(hhuang)

Comment 6

•
4 years ago 
Hi Pavel, Can you help to check those images I listed below have been updated? I didn't see them in the patch.

apps/costcontrol/style/images/widget/ui/no-credit-pattern@1.5x.png
apps/costcontrol/style/images/widget/ui/no-credit-pattern@2x.png
apps/costcontrol/style/images/widget/ui/no-credit-pattern@2.25x.png
apps/costcontrol/style/images/widget/ui/glossy-gradient@1.5x.png
apps/costcontrol/style/images/widget/ui/glossy-gradient@2x.png
apps/costcontrol/style/images/widget/ui/glossy-gradient@2.25x.png

Thank you!
 (Assignee)

Comment 7

•
4 years ago 
Hey Helen,

we don't use `no-credit-pattern` images anymore and the `glossy-gradient` images are here:

https://github.com/mozilla-b2g/gaia/pull/23268/files#diff-8
https://github.com/mozilla-b2g/gaia/pull/23268/files#diff-9
https://github.com/mozilla-b2g/gaia/pull/23268/files#diff-10

:)
Flags: needinfo?(hhuang)

Comment 8

•
4 years ago 
Comment on attachment 8478215 [details] [review]
patch for Gaia/master

It's great! Thanks a lot :)
Attachment #8478215 - Flags: ui-review?(hhuang) → ui-review+
Flags: needinfo?(hhuang)
Attachment #8478215 - Flags: review?(salva)

Comment 9

•
4 years ago 
Comment on attachment 8478215 [details] [review]
patch for Gaia/master

Nice! Thank you for the update.
Attachment #8478215 - Flags: review?(salva) → review+
 (Assignee)

Comment 10

•
4 years ago 
Thanks :)

Landed to master:
https://github.com/mozilla-b2g/gaia/commit/e0a1efa6ab2801401d1769a94a45bae4901609b3
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.