Closed
Bug 1035676
Opened 10 years ago
Closed 10 years ago
[Costcontrol] - check missing images
Categories
(Firefox OS Graveyard :: Gaia::Cost Control, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: pivanov, Assigned: pivanov)
References
Details
Attachments
(2 files)
31.93 KB,
application/zip
|
Details | |
46 bytes,
text/x-github-pull-request
|
salva
:
review+
HHuang
:
ui-review+
|
Details | Review |
We need to check following images: apps/costcontrol/style/images/app/ui/datausage/pattern-3g@2x.png apps/costcontrol/style/images/app/ui/datausage/pattern-3g@2.25x.png apps/costcontrol/style/images/app/ui/datausage/pattern@1.5x.png apps/costcontrol/style/images/app/ui/datausage/pattern@2x.png apps/costcontrol/style/images/app/ui/datausage/pattern@2.25x.png ??? apps/costcontrol/style/images/app/ui/datausage/toggle-bg@1.5x.png ??? apps/costcontrol/style/images/app/ui/datausage/toggle-bg@2x.png ??? apps/costcontrol/style/images/app/ui/datausage/toggle-bg@2.25x.png apps/costcontrol/style/images/app/ui/pattern@1.5x.png apps/costcontrol/style/images/app/ui/pattern@2x.png apps/costcontrol/style/images/app/ui/pattern@2.25x.png apps/costcontrol/style/images/widget/ui/glossy-gradient@1.5x.png apps/costcontrol/style/images/widget/ui/glossy-gradient@2x.png apps/costcontrol/style/images/widget/ui/glossy-gradient@2.25x.png ??? apps/costcontrol/style/images/widget/ui/no-credit-pattern@1.5x.png ??? apps/costcontrol/style/images/widget/ui/no-credit-pattern@2x.png ??? apps/costcontrol/style/images/widget/ui/no-credit-pattern@2.25x.png apps/costcontrol/style/images/widget/ui/pattern-progress@1.5x.png apps/costcontrol/style/images/widget/ui/pattern-progress@2x.png apps/costcontrol/style/images/widget/ui/pattern-progress@2.25x.png apps/costcontrol/style/images/widget/ui/zero-credit@1.5x.png apps/costcontrol/style/images/widget/ui/zero-credit@2x.png apps/costcontrol/style/images/widget/ui/zero-credit@2.25x.png ??? - we need to double check this
Assignee | ||
Updated•10 years ago
|
Summary: [Costcontrol] - remove unused images → [Costcontrol] - check missing images
Assignee | ||
Comment 1•10 years ago
|
||
Hey Stephany, do you know who can help with this images?
Flags: needinfo?(swilkes)
Comment 2•10 years ago
|
||
Patryk or Mike, do you know anyone from visual design who may be able to assist Pavel with missing images (again!)? Thank you!
Flags: needinfo?(swilkes)
Flags: needinfo?(padamczyk)
Flags: needinfo?(mtsai)
Helen is willing to help, although she is not the designer for Cost Control but she can help to find the missing images from massive file database. Thank you, Helen.
Flags: needinfo?(mtsai) → needinfo?(hhuang)
Updated•10 years ago
|
Flags: needinfo?(padamczyk)
Comment 4•10 years ago
|
||
Hi Pavel, the images are ready, please help to update them, thanks!
Flags: needinfo?(hhuang)
Assignee | ||
Comment 5•10 years ago
|
||
Thanks :) Can you ui-r?
Attachment #8478215 -
Flags: ui-review?(hhuang)
Comment 6•10 years ago
|
||
Hi Pavel, Can you help to check those images I listed below have been updated? I didn't see them in the patch. apps/costcontrol/style/images/widget/ui/no-credit-pattern@1.5x.png apps/costcontrol/style/images/widget/ui/no-credit-pattern@2x.png apps/costcontrol/style/images/widget/ui/no-credit-pattern@2.25x.png apps/costcontrol/style/images/widget/ui/glossy-gradient@1.5x.png apps/costcontrol/style/images/widget/ui/glossy-gradient@2x.png apps/costcontrol/style/images/widget/ui/glossy-gradient@2.25x.png Thank you!
Assignee | ||
Comment 7•10 years ago
|
||
Hey Helen, we don't use `no-credit-pattern` images anymore and the `glossy-gradient` images are here: https://github.com/mozilla-b2g/gaia/pull/23268/files#diff-8 https://github.com/mozilla-b2g/gaia/pull/23268/files#diff-9 https://github.com/mozilla-b2g/gaia/pull/23268/files#diff-10 :)
Flags: needinfo?(hhuang)
Comment 8•10 years ago
|
||
Comment on attachment 8478215 [details] [review] patch for Gaia/master It's great! Thanks a lot :)
Attachment #8478215 -
Flags: ui-review?(hhuang) → ui-review+
Flags: needinfo?(hhuang)
Assignee | ||
Updated•10 years ago
|
Attachment #8478215 -
Flags: review?(salva)
Comment 9•10 years ago
|
||
Comment on attachment 8478215 [details] [review] patch for Gaia/master Nice! Thank you for the update.
Attachment #8478215 -
Flags: review?(salva) → review+
Assignee | ||
Comment 10•10 years ago
|
||
Thanks :) Landed to master: https://github.com/mozilla-b2g/gaia/commit/e0a1efa6ab2801401d1769a94a45bae4901609b3
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•