1035680 - [FTU] - check missing images

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::First Time Experience, defect)

Description

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

We need to check following images:

apps/ftu/style/images/[e-mail]
apps/ftu/style/images/[e-mail]
apps/ftu/style/images/[e-mail]
apps/ftu/style/images/[e-mail]
apps/ftu/style/images/[e-mail]
apps/ftu/style/images/[e-mail]
apps/ftu/style/images/[e-mail]
apps/ftu/style/images/[e-mail]
apps/ftu/style/images/[e-mail]
apps/ftu/style/images/[e-mail]
??? apps/ftu/style/images/bg_nosim@[e-mail]
??? apps/ftu/style/images/bg_nosim@[e-mail]
??? apps/ftu/style/images/bg_nosim@[e-mail]
apps/ftu/style/images/[e-mail]
apps/ftu/style/images/[e-mail]
apps/ftu/style/images/[e-mail]
apps/ftu/style/images/[e-mail]
apps/ftu/style/images/[e-mail]
apps/ftu/style/images/timezone/[e-mail]
apps/ftu/style/images/tutorial/[e-mail]
apps/ftu/style/images/tutorial/[e-mail]
apps/ftu/style/images/tutorial/[e-mail]
apps/ftu/style/images/tutorial/[e-mail]
apps/ftu/style/images/tutorial/[e-mail]
apps/ftu/style/images/tutorial/[e-mail]
apps/ftu/style/images/tutorial/[e-mail]
apps/ftu/style/images/tutorial/[e-mail]
apps/ftu/style/images/tutorial/[e-mail]
apps/ftu/style/images/tutorial/[e-mail]
apps/ftu/style/images/tutorial/[e-mail]
apps/ftu/style/images/tutorial/[e-mail]

??? - we need to double check this

Comment 1

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Hey Helen,
can you help with this one too? :)

Comment 2

[Helen Huang [:HHuang]]

Attachment: [e-mail]

Sure! The image apps/ftu/style/images/timezone/[e-mail] is attached, please help to update it.

These images I listed below are only for tablet, we don't need various sizes for them.
- apps/ftu/style/images/arrow_up.png
- apps/ftu/style/images/bg_for_large.png
- apps/ftu/style/images/bg_grey-noise.png
- apps/ftu/style/images/start_for_large.png
- apps/ftu/style/images/thumb_up2.png
- apps/ftu/style/images/tutorial/1_large.png
- apps/ftu/style/images/tutorial/2_large.png
- apps/ftu/style/images/tutorial/3_large.png
- apps/ftu/style/images/tutorial/4_large.png

Also I found there are some missing images caused by naming issue.
- apps/ftu/style/images/[e-mail] is already in Gaia, but the file extension '.png' is lost that causes it seems missing in the system. Could you fix the naming?
- apps/ftu/style/images/bg_nosim@[e-mail], Please help to revise the capital letter 'X' to 'x', therefore, the other sizes images are not needed.
- apps/ftu/style/images/timezone/[e-mail] is an incorrect image that we don't need it, please remove this one.

Thanks!

Comment 3

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Attachment: patch for Gaia/master

Comment 4

[Helen Huang [:HHuang]]

Hi Pavel, I've checked the attachment on Comment 3, Thanks for your help!
Just want to make sure that have you renamed the image [e-mail] to [e-mail]? If yes, I will update the ui-review right away.

Comment 5

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Hey Helen,

yes it's done:
https://github.com/pivanov/gaia/blob/bug-1035680/apps/ftu/style/images/bg_nosim%401.5x.png

Comment 6

[Helen Huang [:HHuang]]

Comment on attachment 8473526 [details] [review]
patch for Gaia/master

Thanks for your help :)

Comment 7

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 8473526 [details] [review]
patch for Gaia/master

r+, please use the png_recompress.sh tool in tools folder to compress them.

Thanks!

Comment 8

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

they are compressed :)

Thanks :)

Landed to master:
https://github.com/mozilla-b2g/gaia/commit/a4c59474d6af356b51a6adf63e16ea8cceb83e22