Closed
Bug 1035680
Opened 10 years ago
Closed 10 years ago
[FTU] - check missing images
Categories
(Firefox OS Graveyard :: Gaia::First Time Experience, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: pivanov, Assigned: pivanov)
References
Details
Attachments
(2 files)
4.18 KB,
image/png
|
Details | |
46 bytes,
text/x-github-pull-request
|
arcturus
:
review+
HHuang
:
ui-review+
|
Details | Review |
We need to check following images: apps/ftu/style/images/arrow_up@1.5x.png apps/ftu/style/images/arrow_up@2x.png apps/ftu/style/images/arrow_up@2.25x.png apps/ftu/style/images/bg_for_large@1.5x.png apps/ftu/style/images/bg_for_large@2x.png apps/ftu/style/images/bg_for_large@2.25x.png apps/ftu/style/images/bg_grey-noise@1.5x.png apps/ftu/style/images/bg_grey-noise@2x.png apps/ftu/style/images/bg_grey-noise@2.25x.png apps/ftu/style/images/bg_nosim@2x.png ??? apps/ftu/style/images/bg_nosim@1.5X@1.5x.png ??? apps/ftu/style/images/bg_nosim@1.5X@2x.png ??? apps/ftu/style/images/bg_nosim@1.5X@2.25x.png apps/ftu/style/images/start_for_large@1.5x.png apps/ftu/style/images/start_for_large@2x.png apps/ftu/style/images/thumb_up2@1.5x.png apps/ftu/style/images/thumb_up2@2x.png apps/ftu/style/images/thumb_up2@2.25x.png apps/ftu/style/images/timezone/+0545@2x.png apps/ftu/style/images/tutorial/1_large@1.5x.png apps/ftu/style/images/tutorial/1_large@2x.png apps/ftu/style/images/tutorial/1_large@2.25x.png apps/ftu/style/images/tutorial/2_large@1.5x.png apps/ftu/style/images/tutorial/2_large@2x.png apps/ftu/style/images/tutorial/2_large@2.25x.png apps/ftu/style/images/tutorial/3_large@1.5x.png apps/ftu/style/images/tutorial/3_large@2x.png apps/ftu/style/images/tutorial/3_large@2.25x.png apps/ftu/style/images/tutorial/4_large@1.5x.png apps/ftu/style/images/tutorial/4_large@2x.png apps/ftu/style/images/tutorial/4_large@2.25x.png ??? - we need to double check this
Assignee | ||
Updated•10 years ago
|
Summary: [FTU] - remove unused images → [FTU] - check missing images
Assignee | ||
Comment 1•10 years ago
|
||
Hey Helen, can you help with this one too? :)
Flags: needinfo?(hhuang)
Comment 2•10 years ago
|
||
Sure! The image apps/ftu/style/images/timezone/+0545@2x.png is attached, please help to update it. These images I listed below are only for tablet, we don't need various sizes for them. - apps/ftu/style/images/arrow_up.png - apps/ftu/style/images/bg_for_large.png - apps/ftu/style/images/bg_grey-noise.png - apps/ftu/style/images/start_for_large.png - apps/ftu/style/images/thumb_up2.png - apps/ftu/style/images/tutorial/1_large.png - apps/ftu/style/images/tutorial/2_large.png - apps/ftu/style/images/tutorial/3_large.png - apps/ftu/style/images/tutorial/4_large.png Also I found there are some missing images caused by naming issue. - apps/ftu/style/images/bg_nosim@2x.png is already in Gaia, but the file extension '.png' is lost that causes it seems missing in the system. Could you fix the naming? - apps/ftu/style/images/bg_nosim@1.5X@1.5x.png, Please help to revise the capital letter 'X' to 'x', therefore, the other sizes images are not needed. - apps/ftu/style/images/timezone/+0445@2x.png is an incorrect image that we don't need it, please remove this one. Thanks!
Flags: needinfo?(hhuang)
Assignee | ||
Comment 3•10 years ago
|
||
Attachment #8473526 -
Flags: ui-review?(hhuang)
Assignee | ||
Updated•10 years ago
|
Attachment #8473526 -
Flags: review?(francisco)
Comment 4•10 years ago
|
||
Hi Pavel, I've checked the attachment on Comment 3, Thanks for your help! Just want to make sure that have you renamed the image bg_nosim@1.5X.png to bg_nosim@1.5x.png? If yes, I will update the ui-review right away.
Flags: needinfo?(pivanov)
Assignee | ||
Comment 5•10 years ago
|
||
Hey Helen, yes it's done: https://github.com/pivanov/gaia/blob/bug-1035680/apps/ftu/style/images/bg_nosim%401.5x.png
Flags: needinfo?(pivanov) → needinfo?(hhuang)
Comment 6•10 years ago
|
||
Comment on attachment 8473526 [details] [review] patch for Gaia/master Thanks for your help :)
Attachment #8473526 -
Flags: ui-review?(hhuang) → ui-review+
Flags: needinfo?(hhuang)
Comment 7•10 years ago
|
||
Comment on attachment 8473526 [details] [review] patch for Gaia/master r+, please use the png_recompress.sh tool in tools folder to compress them. Thanks!
Attachment #8473526 -
Flags: review?(francisco) → review+
Assignee | ||
Comment 8•10 years ago
|
||
they are compressed :) Thanks :) Landed to master: https://github.com/mozilla-b2g/gaia/commit/a4c59474d6af356b51a6adf63e16ea8cceb83e22
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•