1035681 - [Gallery] - check missing images

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Gallery, defect)

Description

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

We need to check following images:

??? apps/gallery/style/images/[e-mail]
??? apps/gallery/style/images/[e-mail]
??? apps/gallery/style/images/[e-mail]
apps/gallery/style/images/[e-mail]
apps/gallery/style/images/[e-mail]
apps/gallery/style/images/[e-mail]
apps/gallery/style/images/[e-mail]
apps/gallery/style/images/[e-mail]
apps/gallery/style/images/[e-mail]
??? apps/gallery/style/images/[e-mail]
??? apps/gallery/style/images/[e-mail]
??? apps/gallery/style/images/[e-mail]
apps/gallery/style/images/[e-mail]
apps/gallery/style/images/[e-mail]
apps/gallery/style/images/[e-mail]
apps/gallery/style/images/[e-mail]
apps/gallery/style/images/[e-mail]
apps/gallery/style/images/[e-mail]
apps/gallery/style/images/[e-mail]
apps/gallery/style/images/[e-mail]
apps/gallery/style/images/[e-mail]
apps/gallery/style/images/[e-mail]
apps/gallery/style/images/[e-mail]
apps/gallery/style/images/[e-mail]
apps/gallery/style/images/[e-mail]
apps/gallery/style/images/[e-mail]
apps/gallery/style/images/[e-mail]
apps/gallery/style/images/ui/[e-mail]
apps/gallery/style/images/ui/[e-mail]
apps/gallery/style/images/ui/[e-mail]
apps/gallery/style/images/ui/[e-mail]
apps/gallery/style/images/ui/[e-mail]
apps/gallery/style/images/ui/[e-mail]
apps/gallery/style/images/ui/[e-mail]
apps/gallery/style/images/ui/[e-mail]

??? - we need to double check this

Comment 1

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Hey Helen,
can you help with this one?

Comment 2

[Helen Huang [:HHuang]]

Attachment: images.zip

Following missing images are attached, please see the zip file.
- apps/gallery/style/images/ui/[e-mail]
- apps/gallery/style/images/ui/[e-mail]
- apps/gallery/style/images/ui/[e-mail]
- apps/gallery/style/images/ui/[e-mail]
- apps/gallery/style/images/ui/[e-mail]

These images are for tablet only, we don't need the other sizes.
- apps/gallery/style/images/fullscreen.png
- apps/gallery/style/images/fullscreen_pressed.png
- apps/gallery/style/images/handle_pressed.png
- apps/gallery/style/images/player_mask.png
- apps/gallery/style/images/selection_mask_L.png
- apps/gallery/style/images/selection_mask_R.png
- apps/gallery/style/images/slider-bg.png
- apps/gallery/style/images/slider-indicator.png
- apps/gallery/style/images/ui/[e-mail]
I also found we don't have apps/gallery/style/images/actionicon_gallery_edit_rotate_30x30.png in Gaia, seems it's not needed. 

Besides, there are some incorrect filenames in Gaia, can you help to revise them? 
- actionicon_gallery_edit_effects_30x30.png need to be renamed to actionicon_gallery_edit_effect_30x30.png ---> also, this image is outdated, the new one in the attachement.
- [e-mail] need to be renamed to [e-mail] 
- [e-mail] need to be renamed to [e-mail]
- [e-mail] need to be renamed to [e-mail]

Please help to relink the renamed images to Gallery app.
Thank you so much!

Comment 3

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Attachment: patch for Gaia/master

Hey Helen,
thanks for the quick answer :) can you check this one?

Comment 4

[Helen Huang [:HHuang]]

Comment on attachment 8474468 [details] [review]
patch for Gaia/master

Cool! Thank you so much for your help :)

Comment 5

[Punam Dahiya [:pdahiya]]

Comment on attachment 8474468 [details] [review]
patch for Gaia/master

Hi Pavel
Attached patch is creating below new file that's not used
 apps/gallery/style/images/actionicon_gallery_edit_effect_30x30.png

Also, we shouldn't be renaming 
rename apps/gallery/style/images/{actionicon_gallery_edit_effect_selected_30x30.png => actionicon_gallery_edit_effects_selected_30x30.png}

as we are using actionicon_gallery_edit_effect_selected_30x30.png. See https://github.com/mozilla-b2g/gaia/blob/master/apps/gallery/style/gallery.css#L798

Thanks

Comment 6

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Comment on attachment 8474468 [details] [review]
patch for Gaia/master

Hey,
thanks for the feedback. You are right! think that now the PR it's OK :)

Comment 7

[Punam Dahiya [:pdahiya]]

Comment on attachment 8474468 [details] [review]
patch for Gaia/master

Looks good. Thanks for the patch!

Comment 8

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Sure :)

Thanks:)

Landed to master:
https://github.com/mozilla-b2g/gaia/commit/e0096044a8e1222504f3448c1dd3ddf0dc9eaf1a