Closed Bug 1035683 Opened 10 years ago Closed 10 years ago

[Music] - check missing images

Categories

(Firefox OS Graveyard :: Gaia::Music, defect)

x86
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: pivanov, Assigned: pivanov)

References

Details

Attachments

(1 file)

We need to check following images:

??? apps/music/style/images/scrubber_pressed@2.25x.png
apps/music/style/images/ui/gradient@2x.png
apps/music/style/images/ui/pattern@1.5x.png
apps/music/style/images/ui/pattern@2x.png
apps/music/style/images/ui/pattern@2.25x.png

??? - we need to double check this
Summary: [Music] - remove unused images → [Music] - check missing images
Attached file patch for Gaia/master
Attachment #8462553 - Flags: review?(squibblyflabbetydoo)
Comment on attachment 8462553 [details] [review]
patch for Gaia/master

We seem to be using both of these images here: https://github.com/mozilla-b2g/gaia/blob/c394b7b4205b6f1a6ca44915fc08650f3ad127ec/apps/music/style/music.css#L46-L47
Attachment #8462553 - Flags: review?(squibblyflabbetydoo) → review-
Comment on attachment 8462553 [details] [review]
patch for Gaia/master

Wait, I read the diff backwards... I think this is ok.
Attachment #8462553 - Flags: review- → review+
:D no problem :)

Thanks :)

Landed to master:
https://github.com/mozilla-b2g/gaia/commit/746b6a1b69e3b9c431de6e32081c438b81a9a8cf
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: