1035706 - [e10s] "tilt toggle" gcli command isn't e10s compatible

Status: RESOLVED DUPLICATE of bug 937166

(DevTools Graveyard :: Graphic Commandline and Toolbar, defect)

Description

[Patrick Brosset <:pbro>]

While working on bug 875871 (specifically child bug 1034601) to have our devtools tests pass in e10s mode, I realized that when the toolbox starts, a tilt-related error is thrown in the console:

ERROR resource://gre/modules/commonjs/toolkit/loader.js -> resource:///modules/devtools/tilt/tilt-utils.js:565 - TypeError: aWindow.QueryInterface is not a function

My best guess is that this error comes from tilt-commands.js in the isChecked function property of the "tilt toggle" command.
isChecked is probably being executed by the toolbox options panel to check/uncheck the 3D view checkbox.

Comment 1

[Patrick Brosset <:pbro>]

Hmm, this might in fact be a gcli bug after all. isChecked is being executed here:
http://mxr.mozilla.org/mozilla-central/source/browser/devtools/shared/DeveloperToolbar.jsm#157
'target' is probably a cross-process object wrapper that doesn't have the QueryInterface property.

Comment 2

[Victor Porof [:vporof][:vp]]

FWIW, Tilt isn't remoted yet: 937166

Comment 3

[Joe Walker [:jwalker]]

My current plans for GCLI are that we should be able to do:

 {
   name: "tilt toggle",
+  process: "page",
   buttonId: "command-button-tilt",
   buttonClass: "command-button command-button-invertable",
   tooltipText: gcli.lookup("tiltToggleTooltip"),
   hidden: true,

And then the command is automatically executed in the content process.

Comment 4

[Chris Peterson [:cpeterson]]

These DevTools bugs should probably block e10s from riding to Aurora.

Comment 5

[Chris Peterson [:cpeterson]]

harthur says these DevTools bugs are not Aurora blockers for e10s.

Comment 7

[Panos Astithas (he/him) [:past] (please ni?)]

I expect bug 937166 will automatically fix this, but please reopen if I'm wrong.