1035708 - [Bluetooth] - remove unused images

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Bluetooth, defect)

Description

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

We need to check following images:

apps/bluetooth/style/images/transfer.png

??? - we need to double check this

Comment 1

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Attachment: patch for Gaia/master

Comment 2

[[e-mail], [e-mail]]

Comment on attachment 8455038 [details] [review]
patch for Gaia/master

Looks like these icons are the old version for files transferring on notification center. And I have moved them to system app(https://github.com/mozilla-b2g/gaia/tree/master/apps/system/style/bluetooth_transfer/images). We can remove them from Bluetooth app. Thanks for your checking.

Comment 3

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Hey Ian,

just to be sure. I can remote these, right?

https://github.com/mozilla-b2g/gaia/blob/master/apps/bluetooth/style/images/icon_bluetooth.png
https://github.com/mozilla-b2g/gaia/blob/master/apps/bluetooth/style/images/icon_bluetooth%401.5x.png
https://github.com/mozilla-b2g/gaia/blob/master/apps/bluetooth/style/images/icon_bluetooth%402.25x.png
https://github.com/mozilla-b2g/gaia/blob/master/apps/bluetooth/style/images/icon_bluetooth%402x.png

I find these lines:
apps/bluetooth/js/pair_manager.js:
   90        var body = pairingInfo.name || _('unnamed-device');
   91        var iconUrl =
   92:         'app://bluetooth.gaiamobile.org/style/images/icon_bluetooth.png';
   93        // We always use tag "pairing-request" to manage these notifications.
   94        var notificationId = 'pairing-request';


apps/bluetooth/test/unit/pair_manager_test.js:
  250        optionsResult = {
  251          body: pairingInfo.name,
  252:         icon: 'app://bluetooth.gaiamobile.org/style/images/icon_bluetooth.png',
  253          tag: 'pairing-request'
  254        };


maybe we need to make some changes there?

Comment 4

[[e-mail], [e-mail]]

The image 'icon_bluetooth.png' is the icon of BT pairing notification currently. What do you want to change for?

Comment 5

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

sorry maybe I misunderstood ... you talk about transfer.png sorry again ...

Comment 6

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Thanks :)

Landed to master:
https://github.com/mozilla-b2g/gaia/commit/88e0a972280bb35847c010b8c3f1481fa80f3847