Closed Bug 1035773 Opened 8 years ago Closed 8 years ago

Change AsyncShutdown timeout crash prefix from "ERROR: " to "FATAL ERROR: "

Categories

(Toolkit :: Async Tooling, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla33

People

(Reporter: emorley, Assigned: emorley)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Adding /^ERROR: / to the TBPL log parser regexes resulted in too many false positives against other failures in green runs.

As such, we need to pick another prefix - and ideally one that can be reused in other cases like this one (where the string can't mention automation or TEST-UNEXPECTED-FAIL; eg bug 1026987).

I'll then add TBPL regex support for this new prefix in bug 1018910.
Comment on attachment 8452264 [details] [diff] [review]
Change AsyncShutdown timeout crash prefix from "ERROR:" to "FATAL ERROR:"

Review of attachment 8452264 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me.
Attachment #8452264 - Flags: review?(dteller) → review+
https://hg.mozilla.org/mozilla-central/rev/1a4c6cb31743
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla33
You need to log in before you can comment on or make changes to this bug.