1035780 - Submit button remains stuck when "Quote text is required" error is displayed

Status: VERIFIED FIXED

(Marketplace Graveyard :: Curation Tools, defect, P2)

Description

[Iulian Timis]

Steps to reproduce:
1. Load Create a Featured app landing page https://marketplace-dev.allizom.org/curate/create/apps
2. Select an app from the App selector and add a slug.
3. Select rating stars from the Quote section (don't add Quote text).
4. Add Description text to the Description section.

Expected results:
"Quote text is required" error is displayed, the user is able to correct the errors and submit the featured app again.

Actual results:
The "Submit" button changes its label to "Submitting..." and it remains stuck like that, even after the user corrects the errors.

Notes/Issues:
Verified on FF33 (Win 7).
Screencast for this issue http://screencast.com/t/l1JoOSbmQHn

Comment 1

[Iulian Timis]

I just noticed that this issue is reproducing for every displayed front-end validation error (App, Slug or Quote is required)

Comment 2

[Davor Spasovski [:spasovski]]

https://github.com/mozilla/transonic/compare/b13d754d8fe8...8b2ce04afe93

This handles the case of the button not being clickable again. Incomplete but required fields on other tabs will still generate errors so it's better to clear those before submitting again.

Comment 3

[Iulian Timis]

Issue is still reproducing in https://marketplace-dev.allizom.org/curate/create/apps on FF33 (Win 7). Please see screencast http://screencast.com/t/CGOv8Ri28Ofy

Comment 4

[Davor Spasovski [:spasovski]]

https://github.com/spasovski/transonic/commit/e07cc8d6ada2bfba284c008546d87ea98ec7a756

That was a very good find. Thanks.

Comment 5

[Iulian Timis]

Verified as fixed in https://marketplace-dev.allizom.org/curate/ on FF33 (Win 7).
Postfix screencast http://screencast.com/t/kieQSq1Zi2H
Closing bug.